Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: src/wasm/wasm-result.h

Issue 2421453002: [wasm] Implement {Compile,Runtime}Error; fix traps from start function (Closed)
Patch Set: Fix merge artefact Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-module.cc ('k') | src/wasm/wasm-result.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-result.h
diff --git a/src/wasm/wasm-result.h b/src/wasm/wasm-result.h
index ecc54e5b7aea4f4d94e18ebed835f555a8c39d26..ffb6367cb204b3e1fdcff0e37175c45b9a76b3ca 100644
--- a/src/wasm/wasm-result.h
+++ b/src/wasm/wasm-result.h
@@ -91,15 +91,16 @@ class V8_EXPORT_PRIVATE ErrorThrower {
: isolate_(isolate), context_(context) {}
~ErrorThrower();
- PRINTF_FORMAT(2, 3) void Error(const char* fmt, ...);
PRINTF_FORMAT(2, 3) void TypeError(const char* fmt, ...);
PRINTF_FORMAT(2, 3) void RangeError(const char* fmt, ...);
+ PRINTF_FORMAT(2, 3) void CompileError(const char* fmt, ...);
+ PRINTF_FORMAT(2, 3) void RuntimeError(const char* fmt, ...);
template <typename T>
- void Failed(const char* error, Result<T>& result) {
+ void CompileFailed(const char* error, Result<T>& result) {
std::ostringstream str;
str << error << result;
- Error("%s", str.str().c_str());
+ CompileError("%s", str.str().c_str());
}
i::Handle<i::Object> Reify() {
« no previous file with comments | « src/wasm/wasm-module.cc ('k') | src/wasm/wasm-result.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698