Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issue 2421313002: [turbofan] Fix JSON escapes in --trace-turbo files. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, danno
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix JSON escapes in --trace-turbo files. This makes the character escaping in the graph visualizer less generic but correct against the JSON spec. The spec has the following definition for valid characters within a double quoted string: char :: any-Unicode-character-except-"-or-\-or-control-character \" \\ \/ \b \f \n \r \t \u four-hex-digits R=bmeurer@chromium.org Committed: https://crrev.com/dd144bbb039a437ce70541ae7a9abc8ccc66a946 Cr-Commit-Position: refs/heads/master@{#40364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M src/compiler/graph-visualizer.cc View 3 chunks +19 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-17 12:32:58 UTC) #3
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-17 12:35:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421313002/1
4 years, 2 months ago (2016-10-17 13:08:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 13:10:18 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 13:10:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd144bbb039a437ce70541ae7a9abc8ccc66a946
Cr-Commit-Position: refs/heads/master@{#40364}

Powered by Google App Engine
This is Rietveld 408576698