[turbofan] Fix JSON escapes in --trace-turbo files.

src/compiler/graph-visualizer.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-visualizer.h"
 
 #include <memory>
 #include <sstream>
 #include <string>
 
@@ skipping 63 matching lines @@
   buffer[full_filename.length()] = '\0';
   return std::unique_ptr<char[]>(buffer);
 }
 
 
 static int SafeId(Node* node) { return node == nullptr ? -1 : node->id(); }
 static const char* SafeMnemonic(Node* node) {
   return node == nullptr ? "null" : node->op()->mnemonic();
 }
 
-#define DEAD_COLOR "#999999"
+class JSONEscaped {
+ public:
+  explicit JSONEscaped(const std::ostringstream& os) : str_(os.str()) {}
 
-class Escaped {
- public:
-  explicit Escaped(const std::ostringstream& os,
-                   const char* escaped_chars = "<>|{}\\")
-      : str_(os.str()), escaped_chars_(escaped_chars) {}
-
-  friend std::ostream& operator<<(std::ostream& os, const Escaped& e) {
-    for (std::string::const_iterator i = e.str_.begin(); i != e.str_.end();
-         ++i) {
-      if (e.needs_escape(*i)) os << "\\";
-      os << *i;
-    }
+  friend std::ostream& operator<<(std::ostream& os, const JSONEscaped& e) {
+    for (char c : e.str_) PipeCharacter(os, c);
     return os;
   }
 
  private:
-  bool needs_escape(char ch) const {
-    for (size_t i = 0; i < strlen(escaped_chars_); ++i) {
-      if (ch == escaped_chars_[i]) return true;
-    }
-    return false;
+  static std::ostream& PipeCharacter(std::ostream& os, char c) {
+    if (c == '"') return os << "\\\"";
+    if (c == '\\') return os << "\\\\";
+    if (c == '\b') return os << "\\b";
+    if (c == '\f') return os << "\\f";
+    if (c == '\n') return os << "\\n";
+    if (c == '\r') return os << "\\r";
+    if (c == '\t') return os << "\\t";
+    return os << c;
   }
 
   const std::string str_;
-  const char* const escaped_chars_;
 };
 
 class JSONGraphNodeWriter {
  public:
   JSONGraphNodeWriter(std::ostream& os, Zone* zone, const Graph* graph,
                       const SourcePositionTable* positions)
       : os_(os),
         all_(zone, graph, false),
         live_(zone, graph, true),
         positions_(positions),
         first_node_(true) {}
 
   void Print() {
     for (Node* const node : all_.reachable) PrintNode(node);
     os_ << "\n";
   }
 
   void PrintNode(Node* node) {
     if (first_node_) {
       first_node_ = false;
     } else {
       os_ << ",\n";
     }
     std::ostringstream label, title, properties;
     node->op()->PrintTo(label, Operator::PrintVerbosity::kSilent);
     node->op()->PrintTo(title, Operator::PrintVerbosity::kVerbose);
     node->op()->PrintPropsTo(properties);
-    os_ << "{\"id\":" << SafeId(node) << ",\"label\":\""
-        << Escaped(label, "\"\\") << "\""
-        << ",\"title\":\"" << Escaped(title, "\"\\") << "\""
+    os_ << "{\"id\":" << SafeId(node) << ",\"label\":\"" << JSONEscaped(label)
+        << "\""
+        << ",\"title\":\"" << JSONEscaped(title) << "\""
         << ",\"live\": " << (live_.IsLive(node) ? "true" : "false")
-        << ",\"properties\":\"" << Escaped(properties, "\"\\") << "\"";
+        << ",\"properties\":\"" << JSONEscaped(properties) << "\"";
     IrOpcode::Value opcode = node->opcode();
     if (IrOpcode::IsPhiOpcode(opcode)) {
       os_ << ",\"rankInputs\":[0," << NodeProperties::FirstControlIndex(node)
           << "]";
       os_ << ",\"rankWithInput\":[" << NodeProperties::FirstControlIndex(node)
           << "]";
     } else if (opcode == IrOpcode::kIfTrue || opcode == IrOpcode::kIfFalse ||
                opcode == IrOpcode::kLoop) {
       os_ << ",\"rankInputs\":[" << NodeProperties::FirstControlIndex(node)
           << "]";
@@ skipping 11 matching lines @@
     os_ << ",\"opinfo\":\"" << node->op()->ValueInputCount() << " v "
         << node->op()->EffectInputCount() << " eff "
         << node->op()->ControlInputCount() << " ctrl in, "
         << node->op()->ValueOutputCount() << " v "
         << node->op()->EffectOutputCount() << " eff "
         << node->op()->ControlOutputCount() << " ctrl out\"";
     if (NodeProperties::IsTyped(node)) {
       Type* type = NodeProperties::GetType(node);
       std::ostringstream type_out;
       type->PrintTo(type_out);
-      os_ << ",\"type\":\"" << Escaped(type_out, "\"\\") << "\"";
+      os_ << ",\"type\":\"" << JSONEscaped(type_out) << "\"";
     }
     os_ << "}";
   }
 
  private:
   std::ostream& os_;
   AllNodes all_;
   AllNodes live_;
   const SourcePositionTable* positions_;
   bool first_node_;
@@ skipping 523 matching lines @@
         os << "]";
       }
       os << std::endl;
     }
   }
   return os;
 }
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8