Issue 2421303002: Fix inspector test in components build

Issue 2421303002: Fix inspector test in components build (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
4 years, 1 month ago

Reviewers:
jgruber, Michael Achenbach

CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix inspector test in components build R=jgruber@chromium.org,machenbach@chromium.org BUG= Committed: https://crrev.com/d1daae6221a10a80a3933301f599ebbdba0887ba Cr-Commit-Position: refs/heads/master@{#40410}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -21 lines)			Patch
M	src/utils.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/inspector/BUILD.gn	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	test/inspector/inspector.gyp	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	test/inspector/inspector-test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 13 (6 generated)

jochen (gone - plz use gerrit)

jgruber, ptal machenbach, can you please add some bots that use the component build and ...

4 years, 2 months ago (2016-10-17 12:18:31 UTC) #4

Michael Achenbach

On 2016/10/17 12:18:31, jochen wrote: > jgruber, ptal > > machenbach, can you please add ...

4 years, 2 months ago (2016-10-17 12:24:34 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421303002/1

4 years, 2 months ago (2016-10-18 19:38:23 UTC) #10

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:05:13 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d1daae6221a10a80a3933301f599ebbdba0887ba
Cr-Commit-Position: refs/heads/master@{#40410}