Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: test/inspector/inspector.gyp

Issue 2421303002: Fix inspector test in components build (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/inspector/BUILD.gn ('k') | test/inspector/inspector-test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/inspector.gyp
diff --git a/test/inspector/inspector.gyp b/test/inspector/inspector.gyp
index c18349c1689e438aa9222dadf3632b4b141a2ced..8c96ae5d75cc74710466dda7e81f5b9633cd3140 100644
--- a/test/inspector/inspector.gyp
+++ b/test/inspector/inspector.gyp
@@ -14,6 +14,7 @@
'dependencies': [
'../../src/v8.gyp:v8_libplatform',
'../../src/v8.gyp:v8_libbase',
+ '../../src/v8.gyp:v8',
],
'include_dirs': [
'../..',
@@ -25,15 +26,6 @@
'task-runner.cc',
'task-runner.h',
],
- 'conditions': [
- ['component=="shared_library"', {
- # inspector-test can't be built against a shared library, so we
- # need to depend on the underlying static target in that case.
- 'dependencies': ['../../src/v8.gyp:v8_maybe_snapshot'],
- }, {
- 'dependencies': ['../../src/v8.gyp:v8'],
- }],
- ],
},
],
'conditions': [
« no previous file with comments | « test/inspector/BUILD.gn ('k') | test/inspector/inspector-test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698