Issue 242123005: Allow posting a Task to Microtasks

Issue 242123005: Allow posting a Task to Microtasks (Closed)

Created:
6 years, 8 months ago by cbiesinger

Modified:
6 years, 8 months ago

Reviewers:
rafaelw, abarth-chromium

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Allow posting a Task to Microtasks ...not just a static callback. This will be used for <img> loading and potential other future users. R=rafaelw@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171965

Patch Set 1 #

Patch Set 2 : use WebThread::Tasl #

Total comments: 3

Patch Set 3 : changes made #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
M	Source/core/dom/Microtask.h	View	1 2	1 chunk	+6 lines, -3 lines	0 comments	Download
M	Source/core/dom/Microtask.cpp	View	1 2	2 chunks	+10 lines, -4 lines	0 comments	Download
M	Source/core/dom/MutationObserver.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

https://codereview.chromium.org/242123005/diff/20001/Source/core/dom/Microtask.cpp File Source/core/dom/Microtask.cpp (right): https://codereview.chromium.org/242123005/diff/20001/Source/core/dom/Microtask.cpp#newcode41 Source/core/dom/Microtask.cpp:41: typedef Vector<blink::WebThread::Task*> MicrotaskQueue; Vector<OwnPtr<blink::WebThread::Task> > ? https://codereview.chromium.org/242123005/diff/20001/Source/core/dom/Microtask.h File Source/core/dom/Microtask.h ...

6 years, 8 months ago (2014-04-18 16:01:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/242123005/40001

6 years, 8 months ago (2014-04-18 18:15:35 UTC) #6

Message was sent while issue was closed.

Change committed as 171965

Expand Messages | Collapse Messages