mustash: Convert TraySupervisedUserTest to AshTest

mustash: Convert TraySupervisedUserTest to AshTest

It only uses common types.

* Add AshTest::GetSystemTrayDelegate, which is used in about 10 places in
other tests.
* Reset the initial login status directly in this test. This is the only
call site for SetInitialLoginStatus(). Continuing to do it in AshTestHelper
would mean I would have to duplicate that call in WmTestHelper, which seems
worse than what I did here.

BUG=654495
TEST=ash_unittests, mash_unittests

Committed: https://crrev.com/d0ded2732e3832c3b1b060098330cf14096c4342
Cr-Commit-Position: refs/heads/master@{#425382}

[James Cook, 2016-10-13 23:02:33]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 23:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-13 23:03:20]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-10-13 23:03:21]

msw, please take a look.

https://codereview.chromium.org/2420783002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/supervised/tray_supervised_user_unittest.cc
(right):

https://codereview.chromium.org/2420783002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/supervised/tray_supervised_user_unittest.cc:63:
test::TestSystemTrayDelegate::SetInitialLoginStatus(LoginStatus::USER);
See CL comment for why I did this. It's ugly, but better than the alternative.

[commit-bot: I haz the power, 2016-10-13 23:07:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 23:07:46]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-10-13 23:11:54]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 23:12:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-14 00:23:53]

lgtm with a nit

https://codereview.chromium.org/2420783002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/supervised/tray_supervised_user_unittest.cc
(right):

https://codereview.chromium.org/2420783002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/supervised/tray_supervised_user_unittest.cc:62: //
Reset the initial login status to the default.
q: should this cache the value before and use AutoReset or similar?

[commit-bot: I haz the power, 2016-10-14 01:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 01:12:49]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-10-14 03:10:52]

msw, I added a ScopedInitialLoginStatus object. Can you take another look?

[James Cook, 2016-10-14 03:11:02]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 03:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 04:07:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 04:07:52]

Dry run: This issue passed the CQ dry run.

[msw, 2016-10-14 16:10:29]

nice, lgtm

https://codereview.chromium.org/2420783002/diff/60001/ash/common/test/test_sy...
File ash/common/test/test_system_tray_delegate.h (right):

https://codereview.chromium.org/2420783002/diff/60001/ash/common/test/test_sy...
ash/common/test/test_system_tray_delegate.h:67: // Allows testing the case when
chrome is restarted right after login (such as a
nit: "such as when a flag is set" or some better wording.

[James Cook, 2016-10-14 16:32:53]

https://codereview.chromium.org/2420783002/diff/60001/ash/common/test/test_sy...
File ash/common/test/test_system_tray_delegate.h (right):

https://codereview.chromium.org/2420783002/diff/60001/ash/common/test/test_sy...
ash/common/test/test_system_tray_delegate.h:67: // Allows testing the case when
chrome is restarted right after login (such as a
On 2016/10/14 16:10:29, msw wrote:
> nit: "such as when a flag is set" or some better wording.

Done.

[James Cook, 2016-10-14 16:46:28]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-14 16:46:29]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2420783002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-14 16:46:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 17:46:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-14 17:50:49]

Description was changed from

==========
mustash: Convert TraySupervisedUserTest to AshTest

It only uses common types.

* Add AshTest::GetSystemTrayDelegate, which is used in about 10 places in
other tests.
* Reset the initial login status directly in this test. This is the only
call site for SetInitialLoginStatus(). Continuing to do it in AshTestHelper
would mean I would have to duplicate that call in WmTestHelper, which seems
worse than what I did here.

BUG=654495
TEST=ash_unittests, mash_unittests
==========

to

==========
mustash: Convert TraySupervisedUserTest to AshTest

It only uses common types.

* Add AshTest::GetSystemTrayDelegate, which is used in about 10 places in
other tests.
* Reset the initial login status directly in this test. This is the only
call site for SetInitialLoginStatus(). Continuing to do it in AshTestHelper
would mean I would have to duplicate that call in WmTestHelper, which seems
worse than what I did here.

BUG=654495
TEST=ash_unittests, mash_unittests

Committed: https://crrev.com/d0ded2732e3832c3b1b060098330cf14096c4342
Cr-Commit-Position: refs/heads/master@{#425382}
==========

[commit-bot: I haz the power, 2016-10-14 17:50:50]

Patchset 6 (id:??) landed as
https://crrev.com/d0ded2732e3832c3b1b060098330cf14096c4342
Cr-Commit-Position: refs/heads/master@{#425382}