mutash: Convert ScreenShareTest/ScreenCaptureTest to AshTest

mutash: Convert ScreenShareTest/ScreenCaptureTest to AshTest

The conversion is mechanical, but exposed the fact that we initialize
chromeos::NetworkHandler in mash_unittests but do not in ash_unittests.
This exposed a crash in the TrayVpn code. Since initializing NetworkHandler
more closely matches how ash runs in production, I chose to skip showing the
VPN tray item if no VPN delegate is available.

BUG=654495
TEST=ash_unittests, mash_unittests

Committed: https://crrev.com/88e3718e8d9b4a20b112ec5258739619d085f6f8
Cr-Commit-Position: refs/heads/master@{#425412}

[James Cook, 2016-10-14 00:13:05]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 00:13:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-14 00:14:40]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-10-14 00:14:40]

stevenjb, please take a look.

For context: AshTest is a replacement for AshTestBase that allows the tests to
be run both in classic ash_unittests and mustash mash_unittests. We're porting
over tests so we get coverage in both environments.

https://codereview.chromium.org/2422453002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/tray_vpn.cc (right):

https://codereview.chromium.org/2422453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/tray_vpn.cc:161: if
(!chromeos::NetworkHandler::IsInitialized())
ash_unittests early-exit here and don't try to create the VPN entry. If they did
they would crash on a null VPNDelegate (since we don't have one of those in
tests).

[commit-bot: I haz the power, 2016-10-14 01:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 01:03:28]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-10-14 02:01:24]

lgtm

[James Cook, 2016-10-14 17:59:03]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-14 17:59:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2422453002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-14 18:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:05:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-14 19:08:36]

Description was changed from

==========
mutash: Convert ScreenShareTest/ScreenCaptureTest to AshTest

The conversion is mechanical, but exposed the fact that we initialize
chromeos::NetworkHandler in mash_unittests but do not in ash_unittests.
This exposed a crash in the TrayVpn code. Since initializing NetworkHandler
more closely matches how ash runs in production, I chose to skip showing the
VPN tray item if no VPN delegate is available.

BUG=654495
TEST=ash_unittests, mash_unittests
==========

to

==========
mutash: Convert ScreenShareTest/ScreenCaptureTest to AshTest

The conversion is mechanical, but exposed the fact that we initialize
chromeos::NetworkHandler in mash_unittests but do not in ash_unittests.
This exposed a crash in the TrayVpn code. Since initializing NetworkHandler
more closely matches how ash runs in production, I chose to skip showing the
VPN tray item if no VPN delegate is available.

BUG=654495
TEST=ash_unittests, mash_unittests

Committed: https://crrev.com/88e3718e8d9b4a20b112ec5258739619d085f6f8
Cr-Commit-Position: refs/heads/master@{#425412}
==========

[commit-bot: I haz the power, 2016-10-14 19:08:37]

Patchset 3 (id:??) landed as
https://crrev.com/88e3718e8d9b4a20b112ec5258739619d085f6f8
Cr-Commit-Position: refs/heads/master@{#425412}