Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: device/vr/test/fake_vr_device.h

Issue 2420743003: mojo VR interface simplified (Closed)
Patch Set: Address haraken@ comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/test/fake_vr_device.h
diff --git a/device/vr/test/fake_vr_device.h b/device/vr/test/fake_vr_device.h
index a72a1941003e99c282a9e9550955aef901166e95..2b149a6cda88b73f2feac746ceffd4c2fa523ec5 100644
--- a/device/vr/test/fake_vr_device.h
+++ b/device/vr/test/fake_vr_device.h
@@ -18,18 +18,33 @@ class FakeVRDevice : public VRDevice {
void InitBasicDevice();
- void SetVRDevice(const VRDisplayPtr& device);
- void SetPose(const VRPosePtr& state);
-
- VRDisplayPtr GetVRDevice() override;
- VRPosePtr GetPose() override;
- void ResetPose() override;
+ void SetVRDevice(const mojom::VRDisplayInfoPtr& device);
+ void SetPose(const mojom::VRPosePtr& state);
+ unsigned UpdatedNum() { return updated; }
+ bool IsDeviceRegistered() {
+ device_registered = !device_registered;
dcheng 2016/11/04 05:12:21 Why does this mutate device_registered?
shaobo.yan 2016/11/05 08:11:38 It means to reset device_registered status when ca
+ return !device_registered;
+ }
+
+ mojom::VRDisplayInfoPtr GetVRDevice() override;
+ mojom::VRPosePtr GetPose(VRServiceImpl* service) override;
+ void ResetPose(VRServiceImpl* service) override;
+
+ bool RequestPresent(VRServiceImpl* service, bool secure_origin) override;
+ void ExitPresent(VRServiceImpl* service) override;
+ void SubmitFrame(VRServiceImpl* service, mojom::VRPosePtr pose) override;
+ void UpdateLayerBounds(VRServiceImpl* service,
+ mojom::VRLayerBoundsPtr leftBounds,
+ mojom::VRLayerBoundsPtr rightBounds) override;
private:
- VREyeParametersPtr InitEye(float fov, float offset, uint32_t size);
+ mojom::VREyeParametersPtr InitEye(float fov, float offset, uint32_t size);
+
+ mojom::VRDisplayInfoPtr device_;
+ mojom::VRPosePtr pose_;
- VRDisplayPtr device_;
- VRPosePtr pose_;
+ unsigned updated;
dcheng 2016/11/04 05:12:21 Nit: fields should end with _
shaobo.yan 2016/11/05 08:11:38 thx and done.
+ bool device_registered;
DISALLOW_COPY_AND_ASSIGN(FakeVRDevice);
};

Powered by Google App Engine
This is Rietveld 408576698