Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Side by Side Diff: device/vr/test/fake_vr_device.h

Issue 2420743003: mojo VR interface simplified (Closed)
Patch Set: Address haraken@ comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_VR_TEST_FAKE_VR_DEVICE_H_ 5 #ifndef DEVICE_VR_TEST_FAKE_VR_DEVICE_H_
6 #define DEVICE_VR_TEST_FAKE_VR_DEVICE_H_ 6 #define DEVICE_VR_TEST_FAKE_VR_DEVICE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "device/vr/vr_device.h" 9 #include "device/vr/vr_device.h"
10 #include "device/vr/vr_device_provider.h" 10 #include "device/vr/vr_device_provider.h"
11 11
12 namespace device { 12 namespace device {
13 13
14 class FakeVRDevice : public VRDevice { 14 class FakeVRDevice : public VRDevice {
15 public: 15 public:
16 explicit FakeVRDevice(VRDeviceProvider* provider); 16 explicit FakeVRDevice(VRDeviceProvider* provider);
17 ~FakeVRDevice() override; 17 ~FakeVRDevice() override;
18 18
19 void InitBasicDevice(); 19 void InitBasicDevice();
20 20
21 void SetVRDevice(const VRDisplayPtr& device); 21 void SetVRDevice(const mojom::VRDisplayInfoPtr& device);
22 void SetPose(const VRPosePtr& state); 22 void SetPose(const mojom::VRPosePtr& state);
23 unsigned UpdatedNum() { return updated; }
24 bool IsDeviceRegistered() {
25 device_registered = !device_registered;
dcheng 2016/11/04 05:12:21 Why does this mutate device_registered?
shaobo.yan 2016/11/05 08:11:38 It means to reset device_registered status when ca
26 return !device_registered;
27 }
23 28
24 VRDisplayPtr GetVRDevice() override; 29 mojom::VRDisplayInfoPtr GetVRDevice() override;
25 VRPosePtr GetPose() override; 30 mojom::VRPosePtr GetPose(VRServiceImpl* service) override;
26 void ResetPose() override; 31 void ResetPose(VRServiceImpl* service) override;
32
33 bool RequestPresent(VRServiceImpl* service, bool secure_origin) override;
34 void ExitPresent(VRServiceImpl* service) override;
35 void SubmitFrame(VRServiceImpl* service, mojom::VRPosePtr pose) override;
36 void UpdateLayerBounds(VRServiceImpl* service,
37 mojom::VRLayerBoundsPtr leftBounds,
38 mojom::VRLayerBoundsPtr rightBounds) override;
27 39
28 private: 40 private:
29 VREyeParametersPtr InitEye(float fov, float offset, uint32_t size); 41 mojom::VREyeParametersPtr InitEye(float fov, float offset, uint32_t size);
30 42
31 VRDisplayPtr device_; 43 mojom::VRDisplayInfoPtr device_;
32 VRPosePtr pose_; 44 mojom::VRPosePtr pose_;
45
46 unsigned updated;
dcheng 2016/11/04 05:12:21 Nit: fields should end with _
shaobo.yan 2016/11/05 08:11:38 thx and done.
47 bool device_registered;
33 48
34 DISALLOW_COPY_AND_ASSIGN(FakeVRDevice); 49 DISALLOW_COPY_AND_ASSIGN(FakeVRDevice);
35 }; 50 };
36 51
37 } // namespace device 52 } // namespace device
38 53
39 #endif // DEVICE_VR_TEST_FAKE_VR_DEVICE_H_ 54 #endif // DEVICE_VR_TEST_FAKE_VR_DEVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698