Make CPDF_Image() constructors saner.

Make CPDF_Image() constructors saner.

Introduce the UniqueDictionary typedef and friends, to allow
moving to unique_ptrs before the Release() deleter issue is
fully resolved.  This will go away down the road.

Committed: https://pdfium.googlesource.com/pdfium/+/4e4d1a662b09d9ee1dc93dd8ee37694d3c4eb519

[Tom Sepez, 2016-10-13 20:48:13]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:48:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-13 20:50:16]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-10-13 20:50:17]

Lei, for review.

[commit-bot: I haz the power, 2016-10-13 20:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:52:09]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-10-13 21:01:24]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 21:01:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:03:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:03:39]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-10-13 21:04:53]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 21:04:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-13 21:06:49]

Description was changed from

==========
Make CPDF_Image() constructors saner.
==========

to

==========
Make CPDF_Image() constructors saner.

Introduce the UniqueDictionary typedef and friends, to allow
moving to unique_ptrs before the Release() deleter issue is
fully resolved.  This will go away down the road.
==========

[commit-bot: I haz the power, 2016-10-13 21:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:14:50]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-13 22:35:01]

https://codereview.chromium.org/2420743002/diff/60001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_dictionary.h (right):

https://codereview.chromium.org/2420743002/diff/60001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_dictionary.h:114: return
UniqueDictionary(ToDictionary(obj.release()));
If |obj| is not a dictionary, then doesn't the release() here leak it?

[Tom Sepez, 2016-10-13 22:46:12]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 22:46:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-13 22:46:30]

https://codereview.chromium.org/2420743002/diff/60001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_dictionary.h (right):

https://codereview.chromium.org/2420743002/diff/60001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_dictionary.h:114: return
UniqueDictionary(ToDictionary(obj.release()));
On 2016/10/13 22:35:01, Lei Zhang wrote:
> If |obj| is not a dictionary, then doesn't the release() here leak it?
right. Fixing all these.

[Lei Zhang, 2016-10-13 22:52:38]

lgtm

https://codereview.chromium.org/2420743002/diff/80001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_dictionary.h (right):

https://codereview.chromium.org/2420743002/diff/80001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_dictionary.h:113: inline UniqueDictionary
ToDictionary(UniqueObject obj) {
Do we still want to explicitly inline / implement in the header?

[Tom Sepez, 2016-10-13 22:56:04]

https://codereview.chromium.org/2420743002/diff/80001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_dictionary.h (right):

https://codereview.chromium.org/2420743002/diff/80001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_dictionary.h:113: inline UniqueDictionary
ToDictionary(UniqueObject obj) {
On 2016/10/13 22:52:38, Lei Zhang wrote:
> Do we still want to explicitly inline / implement in the header?
For now, I think so just to keep them together.

[Tom Sepez, 2016-10-13 22:56:12]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-10-13 22:56:29]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:56:57]

Description was changed from

==========
Make CPDF_Image() constructors saner.

Introduce the UniqueDictionary typedef and friends, to allow
moving to unique_ptrs before the Release() deleter issue is
fully resolved.  This will go away down the road.
==========

to

==========
Make CPDF_Image() constructors saner.

Introduce the UniqueDictionary typedef and friends, to allow
moving to unique_ptrs before the Release() deleter issue is
fully resolved.  This will go away down the road.

Committed:
https://pdfium.googlesource.com/pdfium/+/4e4d1a662b09d9ee1dc93dd8ee37694d3c4e...
==========

[commit-bot: I haz the power, 2016-10-13 22:56:58]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/4e4d1a662b09d9ee1dc93dd8ee37694d3c4e...