core/fpdfapi/page/cpdf_streamcontentparser.cpp - Issue 2420743002: Make CPDF_Image() constructors saner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_streamcontentparser.cpp

Issue 2420743002: Make CPDF_Image() constructors saner. (Closed)

Patch Set: Fix leak Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_streamcontentparser.cpp

diff --git a/core/fpdfapi/page/cpdf_streamcontentparser.cpp b/core/fpdfapi/page/cpdf_streamcontentparser.cpp

index 60c9b527a364f2b171c02eebf122d7457bf4dd9b..7f20b227b61b56c9aa1637498ec0a9c65fc37b44 100644

--- a/core/fpdfapi/page/cpdf_streamcontentparser.cpp

+++ b/core/fpdfapi/page/cpdf_streamcontentparser.cpp

@@ -706,8 +706,7 @@ CPDF_ImageObject* CPDF_StreamContentParser::AddImage(UniqueStream pStream) {

auto pImageObj = pdfium::MakeUnique<CPDF_ImageObject>();

pImageObj->SetOwnedImage(

- pdfium::MakeUnique<CPDF_Image>(m_pDocument, pStream.release(), true));

+ pdfium::MakeUnique<CPDF_Image>(m_pDocument, std::move(pStream)));

return AddImageObject(std::move(pImageObj));

}