Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2420633002: [Cast] Refresh cast button visibility when disableRemotePlayback attribute changes (Closed)
Patch Set: Improved unit tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index b17a53a2ca6cd96c137b027b624f8128d17f453b..b52842c7489b91d0214b6c4c7667d0c5d5ea03b9 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -589,6 +589,8 @@ void HTMLMediaElement::parseAttribute(const QualifiedName& name,
setPlayerPreload();
} else if (name == disableremoteplaybackAttr) {
UseCounter::count(document(), UseCounter::DisableRemotePlaybackAttribute);
+ if (mediaControls())
mlamouri (slow - plz ping) 2016/10/15 00:03:48 If you are worried about calling this too often, y
whywhat 2016/10/15 00:33:21 Done. Missed the fact we get the old value in the
+ mediaControls()->refreshCastButtonVisibility();
} else {
HTMLElement::parseAttribute(name, oldValue, value);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698