Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2420633002: [Cast] Refresh cast button visibility when disableRemotePlayback attribute changes (Closed)
Patch Set: Improved unit tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 invokeLoadAlgorithm(); 582 invokeLoadAlgorithm();
583 } 583 }
584 } else if (name == controlsAttr) { 584 } else if (name == controlsAttr) {
585 UseCounter::count(document(), 585 UseCounter::count(document(),
586 UseCounter::HTMLMediaElementControlsAttribute); 586 UseCounter::HTMLMediaElementControlsAttribute);
587 configureMediaControls(); 587 configureMediaControls();
588 } else if (name == preloadAttr) { 588 } else if (name == preloadAttr) {
589 setPlayerPreload(); 589 setPlayerPreload();
590 } else if (name == disableremoteplaybackAttr) { 590 } else if (name == disableremoteplaybackAttr) {
591 UseCounter::count(document(), UseCounter::DisableRemotePlaybackAttribute); 591 UseCounter::count(document(), UseCounter::DisableRemotePlaybackAttribute);
592 if (mediaControls())
mlamouri (slow - plz ping) 2016/10/15 00:03:48 If you are worried about calling this too often, y
whywhat 2016/10/15 00:33:21 Done. Missed the fact we get the old value in the
593 mediaControls()->refreshCastButtonVisibility();
592 } else { 594 } else {
593 HTMLElement::parseAttribute(name, oldValue, value); 595 HTMLElement::parseAttribute(name, oldValue, value);
594 } 596 }
595 } 597 }
596 598
597 void HTMLMediaElement::finishParsingChildren() { 599 void HTMLMediaElement::finishParsingChildren() {
598 HTMLElement::finishParsingChildren(); 600 HTMLElement::finishParsingChildren();
599 601
600 if (Traversal<HTMLTrackElement>::firstChild(*this)) 602 if (Traversal<HTMLTrackElement>::firstChild(*this))
601 scheduleTextTrackResourceLoad(); 603 scheduleTextTrackResourceLoad();
(...skipping 3487 matching lines...) Expand 10 before | Expand all | Expand 10 after
4089 4091
4090 IntRect HTMLMediaElement::AutoplayHelperClientImpl::absoluteBoundingBoxRect() 4092 IntRect HTMLMediaElement::AutoplayHelperClientImpl::absoluteBoundingBoxRect()
4091 const { 4093 const {
4092 IntRect result; 4094 IntRect result;
4093 if (LayoutObject* object = m_element->layoutObject()) 4095 if (LayoutObject* object = m_element->layoutObject())
4094 result = object->absoluteBoundingBoxRect(); 4096 result = object->absoluteBoundingBoxRect();
4095 return result; 4097 return result;
4096 } 4098 }
4097 4099
4098 } // namespace blink 4100 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698