[Cast] Refresh cast button visibility when disableRemotePlayback attribute changes

[Cast] Refresh cast button visibility when disableRemotePlayback attribute changes

BUG=655642
Committed: https://crrev.com/b9893ae730d1ffb08fad82862e93a371086d13a5
Cr-Commit-Position: refs/heads/master@{#425532}

[whywhat, 2016-10-13 15:44:15]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2016-10-13 15:44:15]

Tentative fix, not really tested yet :)

[whywhat, 2016-10-13 15:44:19]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 15:44:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 17:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:05:43]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-10-13 20:16:32]

Improved unit tests

[whywhat, 2016-10-13 20:18:24]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:18:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[whywhat, 2016-10-13 20:18:59]

I confirmed it works now. The unit tests were conveniently working around the
bug so I fixed them too.

[whywhat, 2016-10-13 20:24:52]

On 2016/10/13 at 20:18:59, whywhat wrote:
> I confirmed it works now. The unit tests were conveniently working around the
bug so I fixed them too.

Although I'm a bit suspicious that parseAttribute is always called when the
attribute changes? Should I check whether the previous value was the same too?

[commit-bot: I haz the power, 2016-10-13 21:45:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:45:16]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-10-15 00:03:48]

lgtm. (the comment is up to you - personally, I wouldn't mind)

https://codereview.chromium.org/2420633002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2420633002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:592: if
(mediaControls())
If you are worried about calling this too often, you can do `if (mediaControls()
&& (oldValue != value))` but I think this is not very important because it would
only apply to people doing `video.disableRemotePlayback = true;` when the value
was already true. Probably not that big of a deal.

[whywhat, 2016-10-15 00:20:13]

Refresh visibility only when the attribute's value changes

[whywhat, 2016-10-15 00:20:39]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2016-10-15 00:20:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2420633002/#ps40001
(title: "Refresh visibility only when the attribute's value changes")

[commit-bot: I haz the power, 2016-10-15 00:21:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[whywhat, 2016-10-15 00:33:21]

https://codereview.chromium.org/2420633002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2420633002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:592: if
(mediaControls())
On 2016/10/15 at 00:03:48, mlamouri wrote:
> If you are worried about calling this too often, you can do `if
(mediaControls() && (oldValue != value))` but I think this is not very important
because it would only apply to people doing `video.disableRemotePlayback =
true;` when the value was already true. Probably not that big of a deal.

Done. Missed the fact we get the old value in the parameters.

[commit-bot: I haz the power, 2016-10-15 02:02:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-15 02:04:18]

Description was changed from

==========
[Cast] Refresh cast button visibility when disableRemotePlayback attribute
changes

BUG=655642
==========

to

==========
[Cast] Refresh cast button visibility when disableRemotePlayback attribute
changes

BUG=655642

Committed: https://crrev.com/b9893ae730d1ffb08fad82862e93a371086d13a5
Cr-Commit-Position: refs/heads/master@{#425532}
==========

[commit-bot: I haz the power, 2016-10-15 02:04:20]

Patchset 3 (id:??) landed as
https://crrev.com/b9893ae730d1ffb08fad82862e93a371086d13a5
Cr-Commit-Position: refs/heads/master@{#425532}