Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2420543003: Merge to M55: Use BrowserAccessibility::GetClosestPlatformObject consistently (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Merge to M55: Use BrowserAccessibility::GetClosestPlatformObject consistently We had two code blocks that were trying to do the same thing as BrowserAccessibility::GetClosestPlatformObject(), but they should have just called that function instead. Also, the two code blocks had a bug in that they considered iframe elements to be leaf nodes, which could cause problems. GetClosestPlatformObject() doesn't have that bug because it only searches within the current frame, so by switching to this function we fix that bug. BUG=652805 Review-Url: https://codereview.chromium.org/2408843002 Cr-Commit-Position: refs/heads/master@{#424196} (cherry picked from commit 6d2ed04992c82f83d1bbbd39520f3e1867b6b28c) Committed: https://chromium.googlesource.com/chromium/src/+/ad7c976158eecc8bf288f1b2e5d1c19793e6630b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 2 months ago (2016-10-13 21:24:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad7c976158eecc8bf288f1b2e5d1c19793e6630b.

Powered by Google App Engine
This is Rietveld 408576698