Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2408843002: Use BrowserAccessibility::GetClosestPlatformObject consistently (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use BrowserAccessibility::GetClosestPlatformObject consistently We had two code blocks that were trying to do the same thing as BrowserAccessibility::GetClosestPlatformObject(), but they should have just called that function instead. Also, the two code blocks had a bug in that they considered iframe elements to be leaf nodes, which could cause problems. GetClosestPlatformObject() doesn't have that bug because it only searches within the current frame, so by switching to this function we fix that bug. BUG=652805 Committed: https://crrev.com/6d2ed04992c82f83d1bbbd39520f3e1867b6b28c Cr-Commit-Position: refs/heads/master@{#424196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
aboxhall
lgtm
4 years, 2 months ago (2016-10-10 17:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408843002/1
4 years, 2 months ago (2016-10-10 18:34:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 18:39:14 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 18:43:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d2ed04992c82f83d1bbbd39520f3e1867b6b28c
Cr-Commit-Position: refs/heads/master@{#424196}

Powered by Google App Engine
This is Rietveld 408576698