Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 2420543002: Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. (Closed)
Patch Set: Use the passed-in build-dir Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/steps.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py
index 505ea773b63042bf002ca98d17295d954aa03ba4..133a8132b2ad29774e286da94f96e1b5a4a7cbef 100644
--- a/scripts/slave/recipe_modules/chromium_tests/steps.py
+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py
@@ -1701,8 +1701,8 @@ class BlinkTest(Test):
'scripts', 'slave', 'chromium', 'archive_layout_test_results.py')
archive_layout_test_args = [
- '--results-dir', results_dir,
'--build-dir', api.chromium.c.build_dir,
Dirk Pranke 2016/10/13 23:34:43 Are you changing this to sort the parameters? If s
qyearsley 2016/10/13 23:48:05 Yeah, that sounds good :-)
+ '--results-dir', results_dir,
'--build-number', buildnumber,
'--builder-name', buildername,
'--gs-bucket', 'gs://chromium-layout-test-archives',

Powered by Google App Engine
This is Rietveld 408576698