Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py.

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import re
 import string
 
 
@@ skipping 1683 matching lines @@
           ])
 
       if suffix in ('', 'with patch'):
         buildername = api.properties['buildername']
         buildnumber = api.properties['buildnumber']
 
         archive_layout_test_results = api.chromium.package_repo_resource(
             'scripts', 'slave', 'chromium', 'archive_layout_test_results.py')
 
         archive_layout_test_args = [
+          '--build-dir', api.chromium.c.build_dir,

[Dirk Pranke, 2016/10/13 23:34:43]

Are you changing this to sort the parameters? If so, you might as well sort all
of them.

However, changing this means you also need to regenerate the recipe
expectations, so you might just leave this file alone :).

[qyearsley, 2016/10/13 23:48:05]

Yeah, that sounds good :-)

           '--results-dir', results_dir,
-          '--build-dir', api.chromium.c.build_dir,
           '--build-number', buildnumber,
           '--builder-name', buildername,
           '--gs-bucket', 'gs://chromium-layout-test-archives',
           '--staging-dir', api.path['cache'].join('chrome_staging'),
         ]
         # TODO(phajdan.jr): Pass gs_acl as a parameter, not build property.
         if api.properties.get('gs_acl'):
           archive_layout_test_args.extend(['--gs-acl', api.properties['gs_acl']])
         archive_result = api.python(
           'archive_webkit_tests_results',
@@ skipping 135 matching lines @@
           args=args)
       api.gsutil.upload(
           temp_output_dir.join(
               '%s-android-chrome.json' % timestamp_string),
           'chromium-annotated-tests', 'android')
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]