Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2420453002: android: Register Display lazily (Closed)

Created:
4 years, 2 months ago by boliu
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Register Display lazily Apparently trying to look up the Display inside onDisplayAdded returns null, and causing crashes. Lazily register display to be added on first use instead to avoid this crash. BUG=655241, 625089 Committed: https://crrev.com/c1d7c92e975b51de35471b539d6840ceabd68374 Cr-Commit-Position: refs/heads/master@{#424901}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java View 1 chunk +1 line, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java View 1 5 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
boliu
ptal
4 years, 2 months ago (2016-10-12 22:56:33 UTC) #9
Ted C
lgtm
4 years, 2 months ago (2016-10-12 23:07:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420453002/20001
4 years, 2 months ago (2016-10-12 23:10:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 23:16:18 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 23:19:51 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c1d7c92e975b51de35471b539d6840ceabd68374
Cr-Commit-Position: refs/heads/master@{#424901}

Powered by Google App Engine
This is Rietveld 408576698