Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

Issue 2420223002: Dispatching errors across iframes don't match webplatform tests
Patch Set: Refactored ScriptStateForErrorEvent, added error handler to the test." Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
index 9acda710530f48c82a190e91d02430a41fcd750f..d268e8d70e5c923c3f47473de4cd14bba0975ccb 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
@@ -106,6 +106,7 @@ v8::Local<v8::Value> V8EventListener::callListenerFunction(
!frame->script().canExecuteScripts(AboutToExecuteScript))
return v8::Local<v8::Value>();
+ ScriptStateForErrorEvent scope(handlerFunction->CreationContext());
haraken 2016/11/02 01:40:18 Add a comment about what this is doing. By the wa
v8::Local<v8::Value> parameters[1] = {jsEvent};
v8::Local<v8::Value> result;
if (!V8ScriptRunner::callFunction(handlerFunction, frame->document(),

Powered by Google App Engine
This is Rietveld 408576698