third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp - Issue 2420223002: Dispatching errors across iframes don't match webplatform tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 2420223002: Dispatching errors across iframes don't match webplatform tests

Patch Set: Refactored ScriptStateForErrorEvent, added error handler to the test." Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

index 841bafc2bbf6b8f22030cf4a17682e62d5252588..5002aee0033d7c2f5b410ae766757f783c15e849 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

@@ -61,6 +61,8 @@ v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(

v8::Local<v8::Function> callFunction =

v8::Local<v8::Function>::Cast(listener);

+ ScriptStateForErrorEvent scope(callFunction->CreationContext());

haraken 2016/11/02 01:40:18 Add a comment about what this is doing.

Yuki 2016/11/02 07:32:43 nit: Avoid a general name "scope", which could be

v8::Local<v8::Object> thisValue = scriptState->context()->Global();

v8::Local<v8::Object> eventObject;