Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2420203003: Turn off Expect-Staple reporting for private roots (Closed)

Created:
4 years, 2 months ago by estark
Modified:
4 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off Expect-Staple reporting for private roots Previously, Expect-Staple reports were sent for certificates chaining to private roots, but with the certificate chains stripped out. However, these reports are mostly just noise for site owners; they tend to indicate that a MITM proxy did not provide an OCSP response, which is to be expected. Moreover, these reports are not useful for answering the interesting question about MITM proxies, which is whether they blindly copy Must-Staple extensions (issue 633732). Thus, this CL disables Expect-Staple reporting for private roots. BUG=656227 Committed: https://crrev.com/53e947a174c199d639065dea59b736b30fb3bf08 Cr-Commit-Position: refs/heads/master@{#425866}

Patch Set 1 #

Patch Set 2 : test fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M net/http/transport_security_state.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/http/transport_security_state.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 5 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
estark
rsleevi, PTAL?
4 years, 2 months ago (2016-10-15 01:50:19 UTC) #5
Ryan Sleevi
lgtm
4 years, 2 months ago (2016-10-18 01:00:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420203003/20001
4 years, 2 months ago (2016-10-18 01:07:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 02:39:54 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:43:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53e947a174c199d639065dea59b736b30fb3bf08
Cr-Commit-Position: refs/heads/master@{#425866}

Powered by Google App Engine
This is Rietveld 408576698