Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: net/http/transport_security_state.h

Issue 2420203003: Turn off Expect-Staple reporting for private roots (Closed)
Patch Set: test fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/transport_security_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index 3326ca246c8f4b4b73c7f33b4071b923a37ab71b..d5116c77605e89d74b783c3b3379667f992779d0 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -313,10 +313,12 @@ class NET_EXPORT TransportSecurityState
// 1. Sending Expect-Staple reports is enabled (via
// |enable_static_expect_staple_|)
// 2. A report sender was provided via SetReportSender().
- // 3. The build is timele (i.e. the preload list is fresh).
+ // 3. The build is timely (i.e. the preload list is fresh).
// 4. The given host is present on the Expect-Staple preload list.
// 5. |ssl_info| indicates the connection did not provide an OCSP response
// indicating a revocation status of GOOD.
+ // 6. The certificate chain in |ssl_info| chains to a known root. Reports
+ // for OCSP responses behind MITM proxies are not useful to site owners.
void CheckExpectStaple(const HostPortPair& host_port_pair,
const SSLInfo& ssl_info,
const std::string& ocsp_response);
« no previous file with comments | « no previous file | net/http/transport_security_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698