Rename ENABLE(DEFAULT_RENDER_THEME) to USE(DEFAULT_RENDER_THEME).

Rename ENABLE(DEFAULT_RENDER_THEME) to USE(DEFAULT_RENDER_THEME) to align with the gyp variable name called use_default_render_theme and with the semantics of the USE() macros.

BUG=286578
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159520

[lgombos, 2013-09-20 15:33:37]

Also moving setting WTF_USE_DEFAULT_RENDER_THEME from gyp build system to
config.h as with other WTF_USE macros.

[abarth-chromium, 2013-09-20 16:49:49]

https://codereview.chromium.org/24202004/diff/1/Source/config.h
File Source/config.h (right):

https://codereview.chromium.org/24202004/diff/1/Source/config.h#newcode189
Source/config.h:189: #endif
This is strange.  Do we do this elsewhere?

[lgombos, 2013-09-20 17:47:19]

https://codereview.chromium.org/24202004/diff/1/Source/config.h
File Source/config.h (right):

https://codereview.chromium.org/24202004/diff/1/Source/config.h#newcode189
Source/config.h:189: #endif
On 2013/09/20 16:49:50, abarth wrote:
> This is strange.  Do we do this elsewhere?

Glad you spotted this; I was not sure about the proposed approach here, but this
is the best I could come up with. I am interested if this is a right direction
as I suspect we will have more of a similar kind of situation.

USE_DEFAULT_RENDER_THEME is a global define set in
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

A few other options:
 1./ Set WTF_USE_DEFAULT_RENDER_THEME in common.gypi at the same time when
USE_DEFAULT_RENDER_THEME is set - I think it is not favorable to set WTF_ scoped
macros in the project global gypi file.

 2./ Leave it as it is and set WTF_USE_DEFAULT_RENDER_THEME in
core/features.gypi - it seems we wanted to get away from this approach and set
WTF_USE in config.h instead

 3./ Do not use USE() guard in blink for global guards and instead just stick to
defined(USE_DEFAULT_RENDER_THEME) as a guard

Do you have other ideas ? Which one you think is more maintainable/less pain
going forward ?

[abarth-chromium, 2013-09-20 17:49:22]

What controls the use_default_render_theme GYP flag?  If
USE(DEFAULT_RENDER_THEME) really is controlled via GYP, then it's ok to set the
macro via GYP.

[lgombos, 2013-09-20 18:00:41]

On 2013/09/20 17:49:22, abarth wrote:
> What controls the use_default_render_theme GYP flag?  If
> USE(DEFAULT_RENDER_THEME) really is controlled via GYP, then it's ok to set
the
> macro via GYP.

Yes, that is the case - USE(DEFAULT_RENDER_THEME) seems to be really controlled
by GYP (right now) -
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&....

Where do you prefer to set WTF_USE_DEFAULT_RENDER_THEME in gyp ? in
core/features.gypi (as it is now) or move it to  build/common.gypi ?

[abarth-chromium, 2013-09-20 18:04:57]

On 2013/09/20 18:00:41, lgombos wrote:
> Where do you prefer to set WTF_USE_DEFAULT_RENDER_THEME in gyp ? in
> core/features.gypi (as it is now) or move it to  build/common.gypi ?

build/common.gypi shouldn't know anything about WTF_ names.  The fact that it
sets the default vector size now is a transient thing and should be removed.

[lgombos, 2013-10-09 07:30:49]

Thanks Adam. Incorporated review feedback.

[abarth-chromium, 2013-10-10 03:45:15]

lgtm

[commit-bot: I haz the power, 2013-10-10 03:45:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/24202004/10001

[commit-bot: I haz the power, 2013-10-10 03:45:31]

Failed to apply patch for Source/core/features.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/core/features.gypi
  |diff --git a/Source/core/features.gypi b/Source/core/features.gypi
  |index
82255f71b39648c06dd3de86f4df66063618b9c5..a10845edf45be3b1622fa7abae84c3b858e1f054
100644
  |--- a/Source/core/features.gypi
  |+++ b/Source/core/features.gypi
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/core/features.gypi
Index: Source/core/features.gypi
diff --git a/Source/core/features.gypi b/Source/core/features.gypi
index
82255f71b39648c06dd3de86f4df66063618b9c5..a10845edf45be3b1622fa7abae84c3b858e1f054
100644
--- a/Source/core/features.gypi
+++ b/Source/core/features.gypi
@@ -98,7 +98,7 @@
       }],
       ['use_default_render_theme==1', {
         'feature_defines': [
-          'ENABLE_DEFAULT_RENDER_THEME=1',
+          'WTF_USE_DEFAULT_RENDER_THEME=1',
         ],
       }],
     ],

[commit-bot: I haz the power, 2013-10-12 13:56:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/24202004/18001

[commit-bot: I haz the power, 2013-10-12 14:51:52]

Change committed as 159520