Source/config.h - Issue 24202004: Rename ENABLE(DEFAULT_RENDER_THEME) to USE(DEFAULT_RENDER_THEME).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/config.h

Issue 24202004: Rename ENABLE(DEFAULT_RENDER_THEME) to USE(DEFAULT_RENDER_THEME). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2013 Apple Inc.	2 * Copyright (C) 2004, 2005, 2006, 2013 Apple Inc.

3 * Copyright (C) 2009 Google Inc. All rights reserved.	3 * Copyright (C) 2009 Google Inc. All rights reserved.

4 * Copyright (C) 2007-2009 Torch Mobile, Inc.	4 * Copyright (C) 2007-2009 Torch Mobile, Inc.

5 * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.	5 * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 164 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
175 #define SKIP_STATIC_CONSTRUCTORS_ON_GCC 1	175 #define SKIP_STATIC_CONSTRUCTORS_ON_GCC 1

176 #endif	176 #endif

177	177

178 #ifndef __STDC_FORMAT_MACROS	178 #ifndef __STDC_FORMAT_MACROS

179 #define __STDC_FORMAT_MACROS 1	179 #define __STDC_FORMAT_MACROS 1

180 #endif	180 #endif

181	181

182 #if OS(LINUX) \|\| OS(ANDROID)	182 #if OS(LINUX) \|\| OS(ANDROID)

183 #define WTF_USE_HARFBUZZ 1	183 #define WTF_USE_HARFBUZZ 1

184 #endif	184 #endif

	185

	186 # Populate USE() macros from global USE_ defines

	187 #if defined(USE_DEFAULT_RENDER_THEME)

	188 #define WTF_USE_DEFAULT_RENDER_THEME 1

	189 #endif
	abarth-chromium 2013/09/20 16:49:50 This is strange. Do we do this elsewhere? This is strange. Do we do this elsewhere? lgombos 2013/09/20 17:47:19 Glad you spotted this; I was not sure about the pr Show quoted text On 2013/09/20 16:49:50, abarth wrote: > This is strange. Do we do this elsewhere? Glad you spotted this; I was not sure about the proposed approach here, but this is the best I could come up with. I am interested if this is a right direction as I suspect we will have more of a similar kind of situation. USE_DEFAULT_RENDER_THEME is a global define set in https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&... A few other options: 1./ Set WTF_USE_DEFAULT_RENDER_THEME in common.gypi at the same time when USE_DEFAULT_RENDER_THEME is set - I think it is not favorable to set WTF_ scoped macros in the project global gypi file. 2./ Leave it as it is and set WTF_USE_DEFAULT_RENDER_THEME in core/features.gypi - it seems we wanted to get away from this approach and set WTF_USE in config.h instead 3./ Do not use USE() guard in blink for global guards and instead just stick to defined(USE_DEFAULT_RENDER_THEME) as a guard Do you have other ideas ? Which one you think is more maintainable/less pain going forward ?
OLD	NEW

« no previous file with comments | « no previous file | Source/core/features.gypi » ('j') | no next file with comments »