Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2420083004: Delete SurfaceTexturePeer (Closed)

Created:
4 years, 2 months ago by tguilbert
Modified:
3 years, 10 months ago
Reviewers:
palmer, kinuko, jbauman, watk
CC:
agrieve+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete SurfaceTexturePeer With WMPA deleted, there is no more use for SurfaceTexturePeer. Use ScopedSurfaceRequestManager instead. This change frees 1.7 KiB. BUG=570711, 339191 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2420083004 Cr-Commit-Position: refs/heads/master@{#449432} Committed: https://chromium.googlesource.com/chromium/src/+/882a7c5b519cb21c62a0fffcf36a5cc0a078b903

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix missed references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -389 lines) Patch
M content/app/android/child_process_service_impl.cc View 1 2 4 chunks +2 lines, -17 lines 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 1 2 chunks +0 lines, -70 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 3 chunks +0 lines, -107 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 1 1 chunk +0 lines, -42 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 2 chunks +0 lines, -21 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/content_test_suite.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/ipc/common/android/surface_texture_peer.h View 1 chunk +0 lines, -39 lines 0 comments Download
D gpu/ipc/common/android/surface_texture_peer.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M gpu/ipc/common/gpu_messages.h View 2 chunks +1 line, -10 lines 0 comments Download
M gpu/ipc/service/stream_texture_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/stream_texture_android.cc View 1 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 37 (24 generated)
tguilbert
Hello, PTAL :) watk@: general review. kinuko@: OWNERS for content/* palmer@: security/OWNERS for gpu/ipc/common/* and ...
3 years, 10 months ago (2017-02-07 21:36:12 UTC) #17
watk
Nice, lgtm
3 years, 10 months ago (2017-02-07 22:09:25 UTC) #18
kinuko
lgtm!
3 years, 10 months ago (2017-02-07 23:29:11 UTC) #21
tguilbert
On 2017/02/07 23:29:11, kinuko wrote: > lgtm! friendly ping :)
3 years, 10 months ago (2017-02-09 20:20:43 UTC) #22
tguilbert
On 2017/02/07 23:29:11, kinuko wrote: > lgtm! friendly ping :)
3 years, 10 months ago (2017-02-09 20:20:43 UTC) #23
palmer
RS LGTM
3 years, 10 months ago (2017-02-09 20:30:00 UTC) #24
tguilbert
On 2017/02/09 20:30:00, palmer wrote: > RS LGTM Sorry for the double ping. Thank you ...
3 years, 10 months ago (2017-02-09 20:33:12 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420083004/80001
3 years, 10 months ago (2017-02-09 20:34:03 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/360892)
3 years, 10 months ago (2017-02-09 20:41:52 UTC) #29
tguilbert
I forgot some aliases in my initial message. jbauman@, can you OWNERS review gpu/ipc/service? Thanks! ...
3 years, 10 months ago (2017-02-09 21:16:19 UTC) #31
jbauman
lgtm
3 years, 10 months ago (2017-02-09 21:33:06 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420083004/80001
3 years, 10 months ago (2017-02-09 21:59:41 UTC) #34
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 22:06:30 UTC) #37
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/882a7c5b519cb21c62a0fffcf36a...

Powered by Google App Engine
This is Rietveld 408576698