ozone: Pick CRTCs with majority of planes.

ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=675755
Committed: https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480
Cr-Original-Commit-Position: refs/heads/master@{#439248}
Review-Url: https://codereview.chromium.org/2420083003
Cr-Commit-Position: refs/heads/master@{#442472}
Committed: https://chromium.googlesource.com/chromium/src/+/dcb4b63e4b07bf55e5ad9c20e9346e42c7eeba84

[Daniele Castagna, 2016-10-14 23:17:11]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 23:17:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-10-14 23:20:02]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 23:20:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-10-14 23:22:58]

Description was changed from

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use with a Display, we should prioritize
CRTCs that support overlays.

BUG=
==========

to

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

BUG=
==========

[commit-bot: I haz the power, 2016-10-15 00:02:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:02:03]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2016-11-01 15:15:05]

Patchset #3 (id:40001) has been deleted

[Daniele Castagna, 2016-11-01 15:21:47]

Description was changed from

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

BUG=
==========

to

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=
==========

[Daniele Castagna, 2016-12-06 00:49:34]

Patchset #6 (id:120001) has been deleted

[Daniele Castagna, 2016-12-13 17:09:33]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org

[Daniele Castagna, 2016-12-13 17:10:14]

dcastagna@chromium.org changed reviewers:
+ hoegsberg@chromium.org

[Daniele Castagna, 2016-12-13 17:12:16]

I waited a little to send this out since every time I tested this it was hitting
a DCHECK in ash.

That DCHECK should be fixed with https://codereview.chromium.org/2557593009/

[dnicoara, 2016-12-13 17:18:54]

lgtm

[Daniele Castagna, 2016-12-16 22:34:40]

crbug.com/671293 has been fixed. Landing this now.

[Daniele Castagna, 2016-12-16 22:34:43]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-12-16 22:35:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 00:18:11]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481927683108150,
"parent_rev": "4ad81d064676293fc00fa5a8faaa2a08addf0ea1", "commit_rev":
"4dd7f8b73501ad3d17d5ac95ee3de93c50587f9b"}

[commit-bot: I haz the power, 2016-12-17 00:18:37]

Description was changed from

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=
==========

to

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=

Review-Url: https://codereview.chromium.org/2420083003
==========

[commit-bot: I haz the power, 2016-12-17 00:18:38]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-12-17 00:22:31]

Description was changed from

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=

Review-Url: https://codereview.chromium.org/2420083003
==========

to

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=

Committed: https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480
Cr-Commit-Position: refs/heads/master@{#439248}
==========

[commit-bot: I haz the power, 2016-12-17 00:22:32]

Patchset 6 (id:??) landed as
https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480
Cr-Commit-Position: refs/heads/master@{#439248}

[Daniele Castagna, 2016-12-21 16:22:14]

A revert of this CL (patchset #6 id:140001) has been created in
https://codereview.chromium.org/2597683002/ by dcastagna@chromium.org.

The reason for reverting is: Reverting since it broke initial modesetting on
some devcies: crbug.com/675755.

[Daniele Castagna, 2017-01-10 01:05:58]

Description was changed from

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=

Committed: https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480
Cr-Commit-Position: refs/heads/master@{#439248}
==========

to

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=675755

Committed: https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480
Cr-Commit-Position: refs/heads/master@{#439248}
==========

[Daniele Castagna, 2017-01-10 01:06:30]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:07:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2017-01-10 01:11:45]

Kristian, with the last change cyan modesets just fine. I checked on kevin and
it works as we expect too.
WDYT? Are you OK landing this or do you prefer to put the new logic behind a
flag?

https://codereview.chromium.org/2420083003/diff/160001/ui/ozone/platform/drm/...
File ui/ozone/platform/drm/common/drm_util.cc (right):

https://codereview.chromium.org/2420083003/diff/160001/ui/ozone/platform/drm/...
ui/ozone/platform/drm/common/drm_util.cc:75: uint32_t assigned_crtc = 0;
Added logic to prefer an already set crtc in case it has the same number of
planes as another one.

[hoegsberg1, 2017-01-10 01:31:46]

hoegsberg@google.com changed reviewers:
+ hoegsberg@google.com

[hoegsberg1, 2017-01-10 01:31:47]

lgtm

[commit-bot: I haz the power, 2017-01-10 03:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:08:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Daniele Castagna, 2017-01-10 03:11:30]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2017-01-10 03:11:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org
Link to the patchset: https://codereview.chromium.org/2420083003/#ps160001
(title: "Prefer already set crtc.")

[commit-bot: I haz the power, 2017-01-10 03:12:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:40:00]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484017890639360,
"parent_rev": "c427878ae12fc982f57cae379f6e21980a8cefcc", "commit_rev":
"dcb4b63e4b07bf55e5ad9c20e9346e42c7eeba84"}

[commit-bot: I haz the power, 2017-01-10 04:40:31]

Description was changed from

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=675755

Committed: https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480
Cr-Commit-Position: refs/heads/master@{#439248}
==========

to

==========
ozone: Pick CRTCs with majority of planes.

When we pick a CRTC to use for a Display, we should prioritize
CRTCs that support the majority of overlays.

This CL also sorts the connectors before assigning CRTCs. If
a connector A supports only a subset of CRTCs supported
by connector B, A should be processed first.

BUG=675755

Committed: https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480
Cr-Original-Commit-Position: refs/heads/master@{#439248}
Review-Url: https://codereview.chromium.org/2420083003
Cr-Commit-Position: refs/heads/master@{#442472}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcb4b63e4b07bf55e5ad9c20e934...
==========

[commit-bot: I haz the power, 2017-01-10 04:40:33]

Committed patchset #7 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/dcb4b63e4b07bf55e5ad9c20e934...