Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2420013005: Remove usage of FOR_EACH_OBSERVER macro in ios/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
droger
CC:
chromium-reviews, cbentzel+watch_chromium.org, markusheintz_, mac-reviews_chromium.org, msramek+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in ios/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed Cr-Commit-Position: refs/heads/master@{#425835}

Patch Set 1 : braces #

Total comments: 1

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -134 lines) Patch
M ios/chrome/browser/browser_state/browser_state_info_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_impl.cc View 1 8 chunks +60 lines, -51 lines 0 comments Download
M ios/chrome/browser/signin/signin_manager_factory.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/chrome_identity_service.mm View 2 chunks +8 lines, -6 lines 0 comments Download
M ios/web/active_state_manager_impl.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M ios/web/web_state/global_web_state_event_tracker.mm View 1 chunk +14 lines, -14 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 9 chunks +50 lines, -39 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:28:55 UTC) #9
droger
lgtm https://codereview.chromium.org/2420013005/diff/20001/ios/chrome/browser/reading_list/reading_list_model_impl.cc File ios/chrome/browser/reading_list/reading_list_model_impl.cc (right): https://codereview.chromium.org/2420013005/diff/20001/ios/chrome/browser/reading_list/reading_list_model_impl.cc#newcode254 ios/chrome/browser/reading_list/reading_list_model_impl.cc:254: for (auto& observer : observers_i) { observers_i: Probably ...
4 years, 2 months ago (2016-10-17 11:42:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420013005/40001
4 years, 2 months ago (2016-10-18 00:25:38 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-18 00:34:06 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 00:36:42 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed
Cr-Commit-Position: refs/heads/master@{#425835}

Powered by Google App Engine
This is Rietveld 408576698