Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: ios/chrome/browser/signin/signin_manager_factory.cc

Issue 2420013005: Remove usage of FOR_EACH_OBSERVER macro in ios/ (Closed)
Patch Set: typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_model_impl.cc ('k') | ios/net/cookies/cookie_store_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/signin/signin_manager_factory.cc
diff --git a/ios/chrome/browser/signin/signin_manager_factory.cc b/ios/chrome/browser/signin/signin_manager_factory.cc
index aef5a4b5adb259fa93a3676c30a8232821c6d834..201daba977b654557a9615f4d7f5be70565ebdcc 100644
--- a/ios/chrome/browser/signin/signin_manager_factory.cc
+++ b/ios/chrome/browser/signin/signin_manager_factory.cc
@@ -75,8 +75,8 @@ void SigninManagerFactory::RemoveObserver(
void SigninManagerFactory::NotifyObserversOfSigninManagerCreationForTesting(
SigninManager* manager) {
- FOR_EACH_OBSERVER(SigninManagerFactoryObserver, observer_list_,
- SigninManagerCreated(manager));
+ for (auto& observer : observer_list_)
+ observer.SigninManagerCreated(manager);
}
std::unique_ptr<KeyedService> SigninManagerFactory::BuildServiceInstanceFor(
@@ -91,17 +91,18 @@ std::unique_ptr<KeyedService> SigninManagerFactory::BuildServiceInstanceFor(
ios::GaiaCookieManagerServiceFactory::GetForBrowserState(
chrome_browser_state)));
service->Initialize(GetApplicationContext()->GetLocalState());
- FOR_EACH_OBSERVER(SigninManagerFactoryObserver, observer_list_,
- SigninManagerCreated(service.get()));
+ for (auto& observer : observer_list_)
+ observer.SigninManagerCreated(service.get());
return std::move(service);
}
void SigninManagerFactory::BrowserStateShutdown(web::BrowserState* context) {
SigninManager* manager =
static_cast<SigninManager*>(GetServiceForBrowserState(context, false));
- if (manager)
- FOR_EACH_OBSERVER(SigninManagerFactoryObserver, observer_list_,
- SigninManagerShutdown(manager));
+ if (manager) {
+ for (auto& observer : observer_list_)
+ observer.SigninManagerShutdown(manager);
+ }
BrowserStateKeyedServiceFactory::BrowserStateShutdown(context);
}
« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_model_impl.cc ('k') | ios/net/cookies/cookie_store_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698