DevTools: allow handing over the raw protocol connection to external clients and back.

DevTools: allow handing over the raw protocol connection to external clients and back.

BUG=656055
Committed: https://crrev.com/6819746d5e8d691edb809467d0cd2b61e666dffc
Cr-Commit-Position: refs/heads/master@{#425504}

[pfeldman, 2016-10-14 17:15:49]

Patchset #1 (id:1) has been deleted

[pfeldman, 2016-10-14 17:23:36]

Patchset #1 (id:20001) has been deleted

[pfeldman, 2016-10-14 17:23:57]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-10-14 18:33:34]

lgtm

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
(right):

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:25:
var fallbackToNetwork = new
WebInspector.ToolbarCheckbox(WebInspector.UIString("Bypass for network"),
WebInspector.UIString("Bypass Service Worker and load resources from the
network"), WebInspector.settings.createSetting("bypassServiceWorker", false));
Should we remove networkManager.bypassServiceWorkerSetting() now?

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:64:
if (!this._manager && this._manager !== target.serviceWorkerManager)
&& -> ||

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:67:
this._manager.removeEventListener(WebInspector.ServiceWorkerManager.Events.RegistrationUpdated,
this._registrationUpdated, this);
Use WebInspector.EventTarget.removeEventListeners.

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
(right):

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:291: var
resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);
Instead of all this, we can use WebInspector.EventTarget.removeEventListeners.

[pfeldman, 2016-10-14 20:03:22]

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
(right):

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:25:
var fallbackToNetwork = new
WebInspector.ToolbarCheckbox(WebInspector.UIString("Bypass for network"),
WebInspector.UIString("Bypass Service Worker and load resources from the
network"), WebInspector.settings.createSetting("bypassServiceWorker", false));
On 2016/10/14 18:33:34, dgozman wrote:
> Should we remove networkManager.bypassServiceWorkerSetting() now?

Done.

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:64:
if (!this._manager && this._manager !== target.serviceWorkerManager)
On 2016/10/14 18:33:34, dgozman wrote:
> && -> ||

Oops :(

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:67:
this._manager.removeEventListener(WebInspector.ServiceWorkerManager.Events.RegistrationUpdated,
this._registrationUpdated, this);
On 2016/10/14 18:33:34, dgozman wrote:
> Use WebInspector.EventTarget.removeEventListeners.

Done.

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
(right):

https://codereview.chromium.org/2419943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:291: var
resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);
On 2016/10/14 18:33:34, dgozman wrote:
> Instead of all this, we can use WebInspector.EventTarget.removeEventListeners.

Done.

[pfeldman, 2016-10-14 20:03:27]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-10-14 20:03:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2419943003/#ps60001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-10-14 20:03:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 23:10:50]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-14 23:12:36]

Description was changed from

==========
DevTools: allow handing over the raw protocol connection to external clients and
back.

BUG=656055
==========

to

==========
DevTools: allow handing over the raw protocol connection to external clients and
back.

BUG=656055

Committed: https://crrev.com/6819746d5e8d691edb809467d0cd2b61e666dffc
Cr-Commit-Position: refs/heads/master@{#425504}
==========

[commit-bot: I haz the power, 2016-10-14 23:12:37]

Patchset 2 (id:??) landed as
https://crrev.com/6819746d5e8d691edb809467d0cd2b61e666dffc
Cr-Commit-Position: refs/heads/master@{#425504}