third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js - Issue 2419943003: DevTools: allow handing over the raw protocol connection to external clients and back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2419943003: DevTools: allow handing over the raw protocol connection to external clients and back. (Closed)

Patch Set: rebaselined Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components_lazy/LineLevelProfile.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

index f9e16d377d2147197222e34381b7a53a8b752b6e..23802863cea05cc431b474b96b867c2aa66ed3a8 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -258,8 +258,7 @@ WebInspector.ConsoleView.prototype = {

targetAdded: function(target)

{

this._viewport.invalidate();

- var hasMultipleCotexts = WebInspector.targetManager.targets(WebInspector.Target.Capability.JS).length > 1;

- this._showAllMessagesCheckbox.element.classList.toggle("hidden", !hasMultipleCotexts);

+ this._updateAllMessagesCheckbox();

/**

@@ -268,6 +267,13 @@ WebInspector.ConsoleView.prototype = {

targetRemoved: function(target)

{

+ this._updateAllMessagesCheckbox();

+ },

+ _updateAllMessagesCheckbox: function()

+ {

+ var hasMultipleCotexts = WebInspector.targetManager.targets(WebInspector.Target.Capability.JS).length > 1;

+ this._showAllMessagesCheckbox.element.classList.toggle("hidden", !hasMultipleCotexts);

_registerWithMessageSink: function()