Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2419913002: Fix some WebContents leaks in prerendering tests (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
CC:
cbentzel+watch_chromium.org, chili+watch_chromium.org, chromium-reviews, dewittj+watch_chromium.org, dimich+watch_chromium.org, fgorski+watch_chromium.org, gavinp+prer_chromium.org, petewil+watch_chromium.org, romax+watch_chromium.org, tburkard+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some WebContents leaks in prerendering tests Ultimately this is blocking some other work because it's causing RenderProcessHostImpl instances to outlive the TestingProfile, and that's undefined behavior. BUG=None R=dimich@chromium.org Committed: https://crrev.com/53772d0e6bedaa0c7ee912a32d7b635fe4e3177e Cr-Commit-Position: refs/heads/master@{#425351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chrome/browser/android/offline_pages/prerender_adapter_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_loader_unittest.cc View 5 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Ken Rockot(use gerrit already)
4 years, 2 months ago (2016-10-13 23:26:08 UTC) #3
Ken Rockot(use gerrit already)
On 2016/10/13 at 23:26:08, Ken Rockot wrote: > Please take a look! I ran into ...
4 years, 2 months ago (2016-10-13 23:27:49 UTC) #4
dougarnett
lgtm
4 years, 2 months ago (2016-10-14 00:23:07 UTC) #8
Ken Rockot(use gerrit already)
On 2016/10/14 at 00:23:07, dougarnett wrote: > lgtm Thanks! Is it OK then to TBR ...
4 years, 2 months ago (2016-10-14 00:26:42 UTC) #9
chromium-reviews
I IM-ed petewil as another owner to do it. On Thu, Oct 13, 2016 at ...
4 years, 2 months ago (2016-10-14 00:31:38 UTC) #10
Pete Williamson
lgtm
4 years, 2 months ago (2016-10-14 16:28:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419913002/1
4 years, 2 months ago (2016-10-14 16:32:19 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 16:39:35 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:41:21 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53772d0e6bedaa0c7ee912a32d7b635fe4e3177e
Cr-Commit-Position: refs/heads/master@{#425351}

Powered by Google App Engine
This is Rietveld 408576698