Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

Issue 2419913002: Fix some WebContents leaks in prerendering tests (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/prerender_adapter_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
index 4c355ee3ef742fa47692330e7a8e6b5fda757906..1f0f1f81d1b65b05a32b01bdc918e19ac89afdd0 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
@@ -10,6 +10,7 @@
#include "base/run_loop.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/web_contents_tester.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -27,7 +28,6 @@ class TestAdapter : public PrerenderAdapter {
disabled_(false),
fail_start_(false),
observer_(observer),
- web_contents_(nullptr),
final_status_(prerender::FINAL_STATUS_MAX) {}
~TestAdapter() override {}
@@ -62,7 +62,7 @@ class TestAdapter : public PrerenderAdapter {
bool disabled_;
bool fail_start_;
PrerenderAdapter::Observer* observer_;
- content::WebContents* web_contents_;
+ std::unique_ptr<content::WebContents> web_contents_;
prerender::FinalStatus final_status_;
DISALLOW_COPY_AND_ASSIGN(TestAdapter);
@@ -78,7 +78,7 @@ void TestAdapter::FailStart() {
void TestAdapter::Configure(content::WebContents* web_contents,
prerender::FinalStatus final_status) {
- web_contents_ = web_contents;
+ web_contents_ = base::WrapUnique(web_contents);
final_status_ = final_status;
}
@@ -98,7 +98,7 @@ bool TestAdapter::StartPrerender(
}
content::WebContents* TestAdapter::GetWebContents() const {
- return web_contents_;
+ return web_contents_.get();
}
prerender::FinalStatus TestAdapter::GetFinalStatus() const {
« no previous file with comments | « chrome/browser/android/offline_pages/prerender_adapter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698