Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 24198006: [blink] Add a DocumentMarker::MisspellingMarkers helper (Closed)

Created:
7 years, 3 months ago by please use gerrit instead
Modified:
7 years, 3 months ago
Reviewers:
tony
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[blink] Add a DocumentMarker::MisspellingMarkers helper This patch adds DocumentMarker::MisspellingMarkers helper to be used instead of (DocumentMarker::Spelling | DocumentMarker::Grammar) through-out Blink. This patch is first of two for issue 295190, which aims to add an invisible DocumentMarker::InCustomSpellcheckDictionary marker to Blink. BUG=295190 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158125

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M Source/core/dom/DocumentMarker.h View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/editing/Editor.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/editing/SpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
please use gerrit instead
Tony: PTAL. This patch is the first of two for https://groups.google.com/a/chromium.org/d/msg/blink-dev/l8liklvqMp8/y2yZXhkaTwQJ.
7 years, 3 months ago (2013-09-20 00:20:17 UTC) #1
tony
LGTM. It's a bit weird that we use subclasses for AllMarkers and MisspellingMarkers. I probably ...
7 years, 3 months ago (2013-09-20 01:24:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/24198006/5001
7 years, 3 months ago (2013-09-20 17:07:56 UTC) #3
commit-bot: I haz the power
Change committed as 158125
7 years, 3 months ago (2013-09-20 17:15:43 UTC) #4
please use gerrit instead
On 2013/09/20 17:15:43, I haz the power (commit-bot) wrote: > Change committed as 158125 That ...
7 years, 3 months ago (2013-09-20 17:19:15 UTC) #5
tony
7 years, 3 months ago (2013-09-20 17:24:26 UTC) #6
Message was sent while issue was closed.
On 2013/09/20 17:19:15, Rouslan Solomakhin wrote:
> On 2013/09/20 17:15:43, I haz the power (commit-bot) wrote:
> > Change committed as 158125
> 
> That was quick. Is it expected that there're no build-bots for blink?

I think it uses try bot status, but I'm not exactly sure when it decides it
needs to re-run some bots because of failures.  I think nbarth or maruel would
know the exact heuristics.

Powered by Google App Engine
This is Rietveld 408576698