Source/web/ContextMenuClientImpl.cpp - Issue 24198006: [blink] Add a DocumentMarker::MisspellingMarkers helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 24198006: [blink] Add a DocumentMarker::MisspellingMarkers helper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index c634e356c4bd7495a7dc247575dcc25ece3827ed..040f44d08d4024146de976111e0dcdef4269891a 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -158,7 +158,7 @@ static String selectMisspellingAsync(Frame* selectedFrame, DocumentMarker& marke

// Caret and range selections always return valid normalized ranges.

RefPtr<Range> selectionRange = selection.toNormalizedRange();

- Vector<DocumentMarker*> markers = selectedFrame->document()->markers()->markersInRange(selectionRange.get(), DocumentMarker::Spelling | DocumentMarker::Grammar);

+ Vector<DocumentMarker*> markers = selectedFrame->document()->markers()->markersInRange(selectionRange.get(), DocumentMarker::MisspellingMarkers());

if (markers.size() != 1)

return String();

marker = *markers[0];

« no previous file with comments | « Source/core/rendering/HitTestResult.cpp ('k') | Source/web/EditorClientImpl.cpp » ('j') | no next file with comments »