Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.h

Issue 2419753002: Prevent FontResource load limit timers from restarting during loading (Closed)
Patch Set: new LoadLimitState, text-only test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/FontResource.h
diff --git a/third_party/WebKit/Source/core/fetch/FontResource.h b/third_party/WebKit/Source/core/fetch/FontResource.h
index 97ea91f2ea76ce92fe8f0dfc61ea812019b653c2..e83ab315a525782642b34205c432c2d1cc84114f 100644
--- a/third_party/WebKit/Source/core/fetch/FontResource.h
+++ b/third_party/WebKit/Source/core/fetch/FontResource.h
@@ -54,7 +54,7 @@ class CORE_EXPORT FontResource final : public Resource {
void setRevalidatingRequest(const ResourceRequest&) override;
void allClientsAndObserversRemoved() override;
- void startLoadLimitTimersIfNeeded();
+ void startLoadLimitTimers();
void setCORSFailed() override { m_corsFailed = true; }
bool isCORSFailed() const { return m_corsFailed; }
@@ -84,7 +84,12 @@ class CORE_EXPORT FontResource final : public Resource {
void fontLoadShortLimitCallback(TimerBase*);
void fontLoadLongLimitCallback(TimerBase*);
- enum LoadLimitState { UnderLimit, ShortLimitExceeded, LongLimitExceeded };
+ enum LoadLimitState {
+ LoadNotStarted,
+ UnderLimit,
+ ShortLimitExceeded,
+ LongLimitExceeded
+ };
std::unique_ptr<FontCustomPlatformData> m_fontData;
String m_otsParsingMessage;
« no previous file with comments | « third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp ('k') | third_party/WebKit/Source/core/fetch/FontResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698