third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp - Issue 2419753002: Prevent FontResource load limit timers from restarting during loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Issue 2419753002: Prevent FontResource load limit timers from restarting during loading (Closed)

Patch Set: new LoadLimitState, text-only test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

index 57e48b357383b9e79a6dbd8d8a53cf995dde2af5..9c3f564d0932a2bd7700a03c479c1a80b3f92954 100644

--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

@@ -231,9 +231,10 @@ PassRefPtr<SimpleFontData> RemoteFontFaceSource::createLoadingFallbackFontData(

void RemoteFontFaceSource::beginLoadIfNeeded() {

if (m_fontSelector->document() && m_font->stillNeedsLoad()) {

m_fontSelector->document()->fetcher()->startLoad(m_font);

+ if (!m_font->isLoaded())

+ m_font->startLoadLimitTimers();

m_histograms.loadStarted();

}

- m_font->startLoadLimitTimersIfNeeded();

if (m_face)

m_face->didBeginLoad();