Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2419713002: [promises] don't store undefined resulting from ResolvePromise (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] don't store undefined resulting from ResolvePromise Committed: https://crrev.com/094e95cdd17ebfd1c10a2f8784b8790124e0cbc4 Cr-Commit-Position: refs/heads/master@{#40241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/js/promise.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gsathya
4 years, 2 months ago (2016-10-12 23:24:18 UTC) #4
adamk
lgtm
4 years, 2 months ago (2016-10-12 23:37:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419713002/1
4 years, 2 months ago (2016-10-12 23:50:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 23:53:32 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 23:54:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/094e95cdd17ebfd1c10a2f8784b8790124e0cbc4
Cr-Commit-Position: refs/heads/master@{#40241}

Powered by Google App Engine
This is Rietveld 408576698