Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2437)

Unified Diff: src/js/promise.js

Issue 2419713002: [promises] don't store undefined resulting from ResolvePromise (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/promise.js
diff --git a/src/js/promise.js b/src/js/promise.js
index 16b7161b7886c4732652da3990148cb962c31c00..ce62cf2379ca4c176b6719b26068439e9ad67c21 100644
--- a/src/js/promise.js
+++ b/src/js/promise.js
@@ -489,13 +489,13 @@ function PromiseResolve(x) {
// Avoid creating resolving functions.
if (this === GlobalPromise) {
var promise = PromiseCreate();
- var resolveResult = ResolvePromise(promise, x);
+ ResolvePromise(promise, x);
return promise;
}
// debugEvent is not so meaningful here as it will be resolved
var promiseCapability = NewPromiseCapability(this, true);
- var resolveResult = %_Call(promiseCapability.resolve, UNDEFINED, x);
+ %_Call(promiseCapability.resolve, UNDEFINED, x);
return promiseCapability.promise;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698