Remove base::ObserverList<T>::Iter::GetNext().

base/observer_list_unittest.cc

Index: base/observer_list_unittest.cc
diff --git a/base/observer_list_unittest.cc b/base/observer_list_unittest.cc
index 299a33f2e896053bf452887191559944c3c53334..c942cef95e080077b3a9cb43aa288a48ecc6c95c 100644
--- a/base/observer_list_unittest.cc
+++ b/base/observer_list_unittest.cc
@@ -895,22 +895,4 @@ TEST(ObserverListTest, BecomesEmptyThanNonEmpty) {
   EXPECT_EQ(-12, b.total);
 }
 
-TEST(ObserverListTest, AddObserverInTheLastObserve) {

[danakj, 2016/10/13 19:38:13]

Why kill the test?

[loyso (OOO), 2016/10/13 23:33:52]

+1. Even without GetNext a user is able to write GetNext-like loops:

auto it = observers.begin();
auto end = observers.end();
do {
  Observer& observer = *it;
  it++;
  observer.Observe();
} while(it != end);

for(auto it = observers.begin(), end = observers.end(); it != end;) {
  Observer& observer = *it;
  it++;
  observer.Observe();  
}

-  using FooList = ObserverList<Foo>;
-  FooList observer_list;
-
-  AddInObserve<FooList> a(&observer_list);
-  Adder b(-1);
-
-  a.SetToAdd(&b);
-  observer_list.AddObserver(&a);
-
-  FooList::Iterator it(&observer_list);
-  Foo* foo;
-  while ((foo = it.GetNext()) != nullptr)
-    foo->Observe(10);
-
-  EXPECT_EQ(-10, b.total);
-}
-
 }  // namespace base