Remove base::ObserverList<T>::Iter::GetNext().

base/observer_list_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/observer_list.h"
 #include "base/observer_list_threadsafe.h"
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 877 matching lines @@
       observer_list.AddObserver(&a);
       observer_list.AddObserver(&b);
       add_observers = false;
     }
   }
 
   EXPECT_EQ(12, a.total);
   EXPECT_EQ(-12, b.total);
 }
 
-TEST(ObserverListTest, AddObserverInTheLastObserve) {

[danakj, 2016/10/13 19:38:13]

Why kill the test?

[loyso (OOO), 2016/10/13 23:33:52]

+1. Even without GetNext a user is able to write GetNext-like loops:

auto it = observers.begin();
auto end = observers.end();
do {
  Observer& observer = *it;
  it++;
  observer.Observe();
} while(it != end);

for(auto it = observers.begin(), end = observers.end(); it != end;) {
  Observer& observer = *it;
  it++;
  observer.Observe();  
}

-  using FooList = ObserverList<Foo>;
-  FooList observer_list;
-
-  AddInObserve<FooList> a(&observer_list);
-  Adder b(-1);
-
-  a.SetToAdd(&b);
-  observer_list.AddObserver(&a);
-
-  FooList::Iterator it(&observer_list);
-  Foo* foo;
-  while ((foo = it.GetNext()) != nullptr)
-    foo->Observe(10);
-
-  EXPECT_EQ(-10, b.total);
-}
-
 }  // namespace base