Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2419663009: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 539
540 bool ChromeClientImpl::tabsToLinks() { 540 bool ChromeClientImpl::tabsToLinks() {
541 return m_webView->tabsToLinks(); 541 return m_webView->tabsToLinks();
542 } 542 }
543 543
544 void ChromeClientImpl::invalidateRect(const IntRect& updateRect) { 544 void ChromeClientImpl::invalidateRect(const IntRect& updateRect) {
545 if (!updateRect.isEmpty()) 545 if (!updateRect.isEmpty())
546 m_webView->invalidateRect(updateRect); 546 m_webView->invalidateRect(updateRect);
547 } 547 }
548 548
549 DISABLE_CFI_PERF
549 void ChromeClientImpl::scheduleAnimation(Widget* widget) { 550 void ChromeClientImpl::scheduleAnimation(Widget* widget) {
550 DCHECK(widget->isFrameView()); 551 DCHECK(widget->isFrameView());
551 FrameView* view = toFrameView(widget); 552 FrameView* view = toFrameView(widget);
552 LocalFrame* frame = view->frame().localFrameRoot(); 553 LocalFrame* frame = view->frame().localFrameRoot();
553 554
554 // If the frame is still being created, it might not yet have a WebWidget. 555 // If the frame is still being created, it might not yet have a WebWidget.
555 // FIXME: Is this the right thing to do? Is there a way to avoid having 556 // FIXME: Is this the right thing to do? Is there a way to avoid having
556 // a local frame root that doesn't have a WebWidget? During initialization 557 // a local frame root that doesn't have a WebWidget? During initialization
557 // there is no content to draw so this call serves no purpose. 558 // there is no content to draw so this call serves no purpose.
558 if (WebLocalFrameImpl::fromFrame(frame) && 559 if (WebLocalFrameImpl::fromFrame(frame) &&
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
1161 if (RuntimeEnabledFeatures::presentationEnabled()) 1162 if (RuntimeEnabledFeatures::presentationEnabled())
1162 PresentationController::provideTo(frame, client->presentationClient()); 1163 PresentationController::provideTo(frame, client->presentationClient());
1163 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) 1164 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())
1164 provideAudioOutputDeviceClientTo(frame, 1165 provideAudioOutputDeviceClientTo(frame,
1165 AudioOutputDeviceClientImpl::create()); 1166 AudioOutputDeviceClientImpl::create());
1166 if (RuntimeEnabledFeatures::installedAppEnabled()) 1167 if (RuntimeEnabledFeatures::installedAppEnabled())
1167 InstalledAppController::provideTo(frame, client->installedAppClient()); 1168 InstalledAppController::provideTo(frame, client->installedAppClient());
1168 } 1169 }
1169 1170
1170 } // namespace blink 1171 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp ('k') | tools/cfi/blacklist.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698