Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2419613002: Add basic swarming UI tests

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
stephana, jcgregorio
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add basic swarming UI tests This uses web-component-tester aka wct BUG=631047

Patch Set 1 #

Patch Set 2 : rebuild #

Patch Set 3 : Touch up docs #

Patch Set 4 : Make sure symlink isn't followed for uploading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -10 lines) Patch
M appengine/swarming/app.yaml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/.gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/Makefile View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M appengine/swarming/ui/README.md View 1 chunk +17 lines, -1 line 0 comments Download
M appengine/swarming/ui/bower.json View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/swarming/ui/build/elements.html View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/swarming/ui/build/js/js.js View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/common/pageable-data.html View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/pageable-data-demo.html View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/js/alias.js View 2 chunks +1 line, -3 lines 0 comments Download
A appengine/swarming/ui/test/common/test-pageable-data.html View 1 chunk +110 lines, -0 lines 0 comments Download
A appengine/swarming/ui/test/js/test-alias.js View 1 chunk +41 lines, -0 lines 0 comments Download
A appengine/swarming/ui/wct.conf.json View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (1 generated)
kjlubick
4 years, 2 months ago (2016-10-12 19:19:21 UTC) #2
As Joe and I discussed, I was able to fit the test framework around the demo
page I already had for pageable-data.

I would like to continue to do this in future tests as well, where sensical, as
it makes it easier to write the tests and iterate on the page.

Powered by Google App Engine
This is Rietveld 408576698