Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2410573002: Make new UI be the default UI (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
Reviewers:
M-A Ruel
CC:
borenet, chromium-reviews, infra-reviews+luci-py_chromium.org, jcgregorio, stephana
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : simplify regex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M appengine/swarming/handlers_frontend.py View 1 7 chunks +12 lines, -9 lines 0 comments Download
M appengine/swarming/handlers_test.py View 2 chunks +2 lines, -1 line 0 comments Download
M appengine/swarming/ui/build/elements.html View 4 chunks +4 lines, -4 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/common-behavior.html View 3 chunks +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/swarming-app.html View 1 chunk +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
kjlubick
4 years, 2 months ago (2016-10-10 19:33:47 UTC) #2
M-A Ruel
lgtm Once it's rolled out, the next change would be to setup forwarders and remove ...
4 years, 2 months ago (2016-10-11 16:19:35 UTC) #3
kjlubick
https://codereview.chromium.org/2410573002/diff/1/appengine/swarming/handlers_frontend.py File appengine/swarming/handlers_frontend.py (right): https://codereview.chromium.org/2410573002/diff/1/appengine/swarming/handlers_frontend.py#newcode827 appengine/swarming/handlers_frontend.py:827: ('/<page:(bot|botlist|task|tasklist|())>', UIHandler), On 2016/10/11 at 16:19:35, M-A Ruel wrote: ...
4 years, 2 months ago (2016-10-11 16:58:12 UTC) #4
M-A Ruel
https://codereview.chromium.org/2410573002/diff/1/appengine/swarming/handlers_frontend.py File appengine/swarming/handlers_frontend.py (right): https://codereview.chromium.org/2410573002/diff/1/appengine/swarming/handlers_frontend.py#newcode827 appengine/swarming/handlers_frontend.py:827: ('/<page:(bot|botlist|task|tasklist|())>', UIHandler), On 2016/10/11 16:58:12, kjlubick wrote: > On ...
4 years, 2 months ago (2016-10-11 16:59:32 UTC) #5
kjlubick
https://codereview.chromium.org/2410573002/diff/1/appengine/swarming/handlers_frontend.py File appengine/swarming/handlers_frontend.py (right): https://codereview.chromium.org/2410573002/diff/1/appengine/swarming/handlers_frontend.py#newcode827 appengine/swarming/handlers_frontend.py:827: ('/<page:(bot|botlist|task|tasklist|())>', UIHandler), On 2016/10/11 at 16:59:31, M-A Ruel wrote: ...
4 years, 2 months ago (2016-10-11 17:09:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410573002/20001
4 years, 2 months ago (2016-10-13 16:51:08 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 16:54:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/1b4140a3a933e208e075d2b61cb150acc6a1f9f5

Powered by Google App Engine
This is Rietveld 408576698