Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5316)

Unified Diff: chrome/browser/ui/webui/settings/site_settings_handler.cc

Issue 2419413002: Deleted CONTENT_SETTINGS_TYPE_FULLSCREEN and MOUSELOCK. (Closed)
Patch Set: Fix more things. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/site_settings_handler.cc
diff --git a/chrome/browser/ui/webui/settings/site_settings_handler.cc b/chrome/browser/ui/webui/settings/site_settings_handler.cc
index b016608313a666d7c8bf9dfe2f7ddd0ec2146dc5..71d5f144c607e1f73669a0ca3df838326d92b6ae 100644
--- a/chrome/browser/ui/webui/settings/site_settings_handler.cc
+++ b/chrome/browser/ui/webui/settings/site_settings_handler.cc
@@ -224,15 +224,6 @@ void SiteSettingsHandler::OnContentSettingChanged(
if (!site_settings::HasRegisteredGroupName(content_type))
return;
- // These content types are deprecated and should not trigger a UI update.
- // TODO(mgiuca): This is really only necessary to avoid breaking
- // SiteSettingsHandlerTest.Incognito. Delete this check when we delete the
- // enum value. https://crbug.com/591896
- if (content_type == CONTENT_SETTINGS_TYPE_FULLSCREEN ||
- content_type == CONTENT_SETTINGS_TYPE_MOUSELOCK) {
- return;
- }
-
if (primary_pattern.ToString().empty()) {
CallJavascriptFunction(
"cr.webUIListenerCallback",
@@ -537,7 +528,6 @@ void SiteSettingsHandler::HandleGetSiteDetails(
CONTENT_SETTINGS_TYPE_POPUPS,
CONTENT_SETTINGS_TYPE_GEOLOCATION,
CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
- CONTENT_SETTINGS_TYPE_FULLSCREEN,
CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC,
CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA,
CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS,

Powered by Google App Engine
This is Rietveld 408576698