Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 2419413002: Deleted CONTENT_SETTINGS_TYPE_FULLSCREEN and MOUSELOCK. (Closed)
Patch Set: Fix more things. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 5c34bace436dd6d4ed96e1d8ea5cd1ba28e940f5..337030021aea39818b40cafd80862eb943677cd4 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -143,16 +143,6 @@ const ExceptionsInfoMap& GetExceptionsInfoMap() {
ContentSettingWithExceptions(
true, UserMetricsAction("Options_DefaultPopupsSettingChanged"))));
exceptions_info_map.insert(std::make_pair(
- CONTENT_SETTINGS_TYPE_FULLSCREEN,
- ContentSettingWithExceptions(
- true,
- UserMetricsAction("Options_DefaultFullScreenSettingChanged"))));
- exceptions_info_map.insert(std::make_pair(
- CONTENT_SETTINGS_TYPE_MOUSELOCK,
- ContentSettingWithExceptions(
- true,
- UserMetricsAction("Options_DefaultMouseLockSettingChanged"))));
- exceptions_info_map.insert(std::make_pair(
CONTENT_SETTINGS_TYPE_PPAPI_BROKER,
ContentSettingWithExceptions(
true,
@@ -1096,14 +1086,6 @@ void ContentSettingsHandler::UpdateZoomLevelsExceptionsView() {
void ContentSettingsHandler::UpdateExceptionsViewFromHostContentSettingsMap(
ContentSettingsType type) {
- // Fullscreen and mouse lock have no global settings to update.
- // TODO(mgiuca): Delete this after removing these content settings entirely
- // (https://crbug.com/591896).
- if (type == CONTENT_SETTINGS_TYPE_FULLSCREEN ||
- type == CONTENT_SETTINGS_TYPE_MOUSELOCK) {
- return;
- }
-
base::ListValue exceptions;
HostContentSettingsMap* settings_map =
HostContentSettingsMapFactory::GetForProfile(GetProfile());

Powered by Google App Engine
This is Rietveld 408576698