|
|
Created:
4 years, 2 months ago by yan0422.wang Modified:
4 years, 1 month ago CC:
chromium-reviews, jln+watch_chromium.org, rickyz+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClose the file handle before exiting the function
When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd".
BUG=n/a
Committed: https://crrev.com/35feaa96a87aad71ed508b825ebc85f9dacd0977
Cr-Commit-Position: refs/heads/master@{#427018}
Patch Set 1 #Messages
Total messages: 22 (10 generated)
Description was changed from ========== Close the file handle before exiting the function When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd". BUG=n/a ========== to ========== Close the file handle before exiting the function When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd". BUG=n/a ==========
yan0422.wang@samsung.com changed reviewers: + jln@chromium.org, jorgelo@chromium.org
Fixed a file handle not close issue. line 61 in sandbox/linux/suid/process_util_linux.c
jorgelo@chromium.org changed reviewers: + rickyz@chromium.org
This looks reasonable to me, although the setuid code is mostly deprecated and AFAICT only kept around for distros who don't want to use user namespaces, right Ricky? lgtm
lgtm
The CQ bit was checked by yan0422.wang@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author yan0422.wang@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by yan0422.wang@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author yan0422.wang@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
On 2016/10/19 03:04:25, commit-bot: I haz the power wrote: > The author mailto:yan0422.wang@samsung.com has not signed Google Contributor License > Agreement. Please visit https://cla.developers.google.com to sign and manage > CLA. Wang, you're gonna have to sign the CLA before you can submit. Re-checking the commit box is not gonna work.
The CQ bit was checked by yan0422.wang@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Close the file handle before exiting the function When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd". BUG=n/a ========== to ========== Close the file handle before exiting the function When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd". BUG=n/a ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Close the file handle before exiting the function When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd". BUG=n/a ========== to ========== Close the file handle before exiting the function When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd". BUG=n/a Committed: https://crrev.com/35feaa96a87aad71ed508b825ebc85f9dacd0977 Cr-Commit-Position: refs/heads/master@{#427018} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/35feaa96a87aad71ed508b825ebc85f9dacd0977 Cr-Commit-Position: refs/heads/master@{#427018}
Message was sent while issue was closed.
On 2016/10/19 13:35:02, Jorge Lucangeli Obes wrote: > On 2016/10/19 03:04:25, commit-bot: I haz the power wrote: > > The author mailto:yan0422.wang@samsung.com has not signed Google Contributor > License > > Agreement. Please visit https://cla.developers.google.com to sign and manage > > CLA. > > Wang, you're gonna have to sign the CLA before you can submit. Re-checking the > commit box is not gonna work. I added Wang to the CLA (just now). Sorry for the delay. Not sure why the patch landed, but Wang should be all set now. |