Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2419383008: Close the file handle before exiting the function (Closed)

Created:
4 years, 2 months ago by yan0422.wang
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jln+watch_chromium.org, rickyz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close the file handle before exiting the function When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd". BUG=n/a Committed: https://crrev.com/35feaa96a87aad71ed508b825ebc85f9dacd0977 Cr-Commit-Position: refs/heads/master@{#427018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/suid/process_util_linux.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
yan0422.wang
Fixed a file handle not close issue. line 61 in sandbox/linux/suid/process_util_linux.c
4 years, 2 months ago (2016-10-18 12:28:16 UTC) #3
Jorge Lucangeli Obes
This looks reasonable to me, although the setuid code is mostly deprecated and AFAICT only ...
4 years, 2 months ago (2016-10-18 13:38:52 UTC) #5
rickyz (no longer on Chrome)
lgtm
4 years, 2 months ago (2016-10-18 20:19:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419383008/1
4 years, 2 months ago (2016-10-19 02:38:34 UTC) #8
commit-bot: I haz the power
The author yan0422.wang@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 2 months ago (2016-10-19 02:38:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419383008/1
4 years, 2 months ago (2016-10-19 03:04:23 UTC) #12
commit-bot: I haz the power
The author yan0422.wang@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 2 months ago (2016-10-19 03:04:25 UTC) #14
Jorge Lucangeli Obes
On 2016/10/19 03:04:25, commit-bot: I haz the power wrote: > The author mailto:yan0422.wang@samsung.com has not ...
4 years, 2 months ago (2016-10-19 13:35:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419383008/1
4 years, 2 months ago (2016-10-24 05:27:07 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-24 05:52:33 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/35feaa96a87aad71ed508b825ebc85f9dacd0977 Cr-Commit-Position: refs/heads/master@{#427018}
4 years, 2 months ago (2016-10-24 05:54:33 UTC) #21
lgombos
4 years, 1 month ago (2016-10-25 02:21:59 UTC) #22
Message was sent while issue was closed.
On 2016/10/19 13:35:02, Jorge Lucangeli Obes wrote:
> On 2016/10/19 03:04:25, commit-bot: I haz the power wrote:
> > The author mailto:yan0422.wang@samsung.com has not signed Google Contributor
> License
> > Agreement. Please visit https://cla.developers.google.com to sign and manage
> > CLA.
> 
> Wang, you're gonna have to sign the CLA before you can submit. Re-checking the
> commit box is not gonna work.

I added Wang to the CLA (just now). Sorry for the delay. 
Not sure why the patch landed, but Wang should be all set now.

Powered by Google App Engine
This is Rietveld 408576698