sandbox/linux/suid/process_util_linux.c - Issue 2419383008: Close the file handle before exiting the function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/suid/process_util_linux.c

Issue 2419383008: Close the file handle before exiting the function (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/suid/process_util_linux.c

diff --git a/sandbox/linux/suid/process_util_linux.c b/sandbox/linux/suid/process_util_linux.c

index 40949bd6ac50662452dcb2842514a47392d63adf..d28d5766c348590a72d602618919fa8fb65a15e8 100644

--- a/sandbox/linux/suid/process_util_linux.c

+++ b/sandbox/linux/suid/process_util_linux.c

@@ -59,6 +59,7 @@ bool AdjustOOMScore(pid_t process, int score) {

fd = openat(dirfd, "oom_adj", O_WRONLY);

if (fd < 0) {

// Nope, that doesn't work either.

+ close(dirfd);

return false;

} else {

// If we're using the old oom_adj file, the allowed range is now

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »