base/values.cc - Issue 2419363002: Remove deprecated ListValue::Append(Value*) overload on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.cc

Issue 2419363002: Remove deprecated ListValue::Append(Value*) overload on CrOS. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.cc

diff --git a/base/values.cc b/base/values.cc

index 2564e09ed1182f80abb76e5b494753db122e30e1..f00a03f8d3097896b7176052368cfdbb7fbfb8dd 100644

--- a/base/values.cc

+++ b/base/values.cc

@@ -1045,7 +1045,7 @@ void ListValue::Append(std::unique_ptr<Value> in_value) {

list_.push_back(std::move(in_value));

}

-#if !defined(OS_LINUX) || defined(OS_CHROMEOS)

+#if !defined(OS_LINUX)

void ListValue::Append(Value* in_value) {

DCHECK(in_value);

Append(WrapUnique(in_value));

« no previous file with comments | « base/values.h ('k') | no next file » | no next file with comments »